Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit b602463

Browse files
committedFeb 17, 2025·
Merge remote-tracking branch 'upstream/release/v2.13.x' into release-option
2 parents 310a7b7 + 7d3ac05 commit b602463

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed
 

‎.github/workflows/build-common.yml

+2
Original file line numberDiff line numberDiff line change
@@ -191,6 +191,8 @@ jobs:
191191
run: ./gradlew check spdxSbom -x javadoc -x spotlessCheck -PskipTests=true ${{ inputs.no-build-cache && '--no-build-cache' || '' }}
192192

193193
- name: Check for jApiCmp diffs
194+
# The jApiCmp diff compares current to latest, which isn't appropriate for release branches
195+
if: ${{ !startsWith(github.ref_name, 'release/') && !startsWith(github.base_ref, 'release/') }}
194196
run: |
195197
# need to "git add" in case any generated files did not already exist
196198
git add docs/apidiffs

‎smoke-tests-otel-starter/spring-boot-3/src/test/java/io/opentelemetry/spring/smoketest/OtelSpringStarterSmokeTest.java

+10-2
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,7 @@ class OtelSpringStarterSmokeTest extends AbstractOtelSpringStarterSmokeTest {
2626

2727
@Override
2828
protected void assertAdditionalMetrics() {
29-
if (System.getProperty("org.graalvm.nativeimage.imagecode") != null) {
30-
// GraalVM native image does not support JFR
29+
if (!isFlightRecorderAvailable()) {
3130
return;
3231
}
3332

@@ -50,4 +49,13 @@ protected void assertAdditionalMetrics() {
5049
"io.opentelemetry.runtime-telemetry-java17", metric, AbstractIterableAssert::isNotEmpty);
5150
}
5251
}
52+
53+
private static boolean isFlightRecorderAvailable() {
54+
try {
55+
return (boolean)
56+
Class.forName("jdk.jfr.FlightRecorder").getMethod("isAvailable").invoke(null);
57+
} catch (ReflectiveOperationException exception) {
58+
return false;
59+
}
60+
}
5361
}

0 commit comments

Comments
 (0)
Please sign in to comment.