Skip to content

Commit c60f94e

Browse files
committed
make elasticsearch-* indy compatible
1 parent 0259a9f commit c60f94e

File tree

2 files changed

+10
-9
lines changed

2 files changed

+10
-9
lines changed

instrumentation/elasticsearch/elasticsearch-api-client-7.16/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/apiclient/ElasticsearchApiClientInstrumentationModule.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@
1212
import com.google.auto.service.AutoService;
1313
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1414
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
15+
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
1516
import java.util.List;
1617
import net.bytebuddy.matcher.ElementMatcher;
1718

1819
@AutoService(InstrumentationModule.class)
19-
public class ElasticsearchApiClientInstrumentationModule extends InstrumentationModule {
20+
public class ElasticsearchApiClientInstrumentationModule extends InstrumentationModule
21+
implements ExperimentalInstrumentationModule {
2022
public ElasticsearchApiClientInstrumentationModule() {
2123
super("elasticsearch-api-client", "elasticsearch-api-client-7.16", "elasticsearch");
2224
}
@@ -31,10 +33,8 @@ public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
3133
}
3234

3335
@Override
34-
public boolean isIndyModule() {
35-
// java.lang.ClassCastException: class
36-
// io.opentelemetry.javaagent.shaded.instrumentation.elasticsearch.rest.internal.ElasticsearchEndpointDefinition cannot be cast to class io.opentelemetry.javaagent.shaded.instrumentation.elasticsearch.rest.internal.ElasticsearchEndpointDefinition (io.opentelemetry.javaagent.shaded.instrumentation.elasticsearch.rest.internal.ElasticsearchEndpointDefinition is in unnamed module of loader io.opentelemetry.javaagent.tooling.instrumentation.indy.InstrumentationModuleClassLoader @6baee63b; io.opentelemetry.javaagent.shaded.instrumentation.elasticsearch.rest.internal.ElasticsearchEndpointDefinition is in unnamed module of loader 'app')
37-
return false;
36+
public String getModuleGroup() {
37+
return "elasticsearch";
3838
}
3939

4040
@Override

instrumentation/elasticsearch/elasticsearch-rest-7.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/elasticsearch/rest/v7_0/ElasticsearchRest7InstrumentationModule.java

+5-4
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,13 @@
1212
import com.google.auto.service.AutoService;
1313
import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
1414
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
15+
import io.opentelemetry.javaagent.extension.instrumentation.internal.ExperimentalInstrumentationModule;
1516
import java.util.List;
1617
import net.bytebuddy.matcher.ElementMatcher;
1718

1819
@AutoService(InstrumentationModule.class)
19-
public class ElasticsearchRest7InstrumentationModule extends InstrumentationModule {
20+
public class ElasticsearchRest7InstrumentationModule extends InstrumentationModule
21+
implements ExperimentalInstrumentationModule {
2022
public ElasticsearchRest7InstrumentationModule() {
2123
super("elasticsearch-rest", "elasticsearch-rest-7.0", "elasticsearch");
2224
}
@@ -33,9 +35,8 @@ public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
3335
}
3436

3537
@Override
36-
public boolean isIndyModule() {
37-
// shares a virtual field with elasticsearch-api-client
38-
return false;
38+
public String getModuleGroup() {
39+
return "elasticsearch";
3940
}
4041

4142
@Override

0 commit comments

Comments
 (0)