Skip to content

Commit d1594a1

Browse files
committed
Fix NullPointerException which caused spans not to be created
1 parent 79c0d1e commit d1594a1

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/messaging/MessagingNetworkAttributesExtractor.java

+8-2
Original file line numberDiff line numberDiff line change
@@ -38,10 +38,16 @@ public static <REQUEST, RESPONSE> MessagingNetworkAttributesExtractor<REQUEST, R
3838
@Override
3939
public void onStart(AttributesBuilder attributes, Context parentContext, REQUEST request) {
4040
attributes.put(NETWORK_PEER_ADDRESS, getter.getNetworkPeerAddress(request, null));
41-
attributes.put(NETWORK_PEER_PORT, getter.getNetworkPeerPort(request, null));
41+
Integer networkPeerPort = getter.getNetworkPeerPort(request, null);
42+
if (networkPeerPort != null) {
43+
attributes.put(NETWORK_PEER_PORT, networkPeerPort);
44+
}
4245

4346
attributes.put(SERVER_ADDRESS, getter.getServerAddress(request));
44-
attributes.put(SERVER_PORT, getter.getServerPort(request));
47+
Integer serverPort = getter.getServerPort(request);
48+
if (serverPort != null) {
49+
attributes.put(SERVER_PORT, serverPort);
50+
}
4551
}
4652

4753
@Override

0 commit comments

Comments
 (0)