Skip to content

Commit d470a92

Browse files
committed
address review comments
1 parent 5b2b1b6 commit d470a92

File tree

5 files changed

+5
-14
lines changed

5 files changed

+5
-14
lines changed

instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/latestDepTest/java/io/opentelemetry/javaagent/instrumentation/vertx/reactive/client/VertxRxCircuitBreakerWebClientTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
109109
optionsBuilder.disableTestRedirects();
110110
optionsBuilder.disableTestHttps();
111111
optionsBuilder.disableTestReadTimeout();
112-
optionsBuilder.disableTestNonStandardHttpMethod();
113112
optionsBuilder.setHttpAttributes(VertxRxCircuitBreakerWebClientTest::getHttpAttributes);
114113
optionsBuilder.setExpectedClientSpanNameMapper(
115114
VertxRxCircuitBreakerWebClientTest::expectedClientSpanName);

instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/latestDepTest/java/io/opentelemetry/javaagent/instrumentation/vertx/reactive/client/VertxRxWebClientTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,6 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
7474
optionsBuilder.disableTestRedirects();
7575
optionsBuilder.disableTestHttps();
7676
optionsBuilder.disableTestReadTimeout();
77-
optionsBuilder.disableTestNonStandardHttpMethod();
7877
optionsBuilder.setHttpAttributes(VertxRxWebClientTest::getHttpAttributes);
7978
optionsBuilder.setClientSpanErrorMapper(VertxRxWebClientTest::clientSpanError);
8079
optionsBuilder.setExpectedClientSpanNameMapper(VertxRxWebClientTest::expectedClientSpanName);

instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/latestDepTest/java/io/opentelemetry/javaagent/instrumentation/vertx/reactive/server/VertxReactiveWebServer.java

+1-4
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,7 @@
33
* SPDX-License-Identifier: Apache-2.0
44
*/
55

6-
package io.opentelemetry.javaagent.instrumentation.vertx.reactive.server; /*
7-
* Copyright The OpenTelemetry Authors
8-
* SPDX-License-Identifier: Apache-2.0
9-
*/
6+
package io.opentelemetry.javaagent.instrumentation.vertx.reactive.server;
107

118
import static io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint.SUCCESS;
129

instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/latestDepTest/java/io/opentelemetry/javaagent/instrumentation/vertx/reactive/server/VertxRxCircuitBreakerHttpServerTest.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,8 @@ public void start(Promise<Void> startPromise) {
5454
CircuitBreaker.create(
5555
"my-circuit-breaker",
5656
vertx,
57-
new CircuitBreakerOptions()
58-
.setTimeout(
59-
-1) // Disable the timeout otherwise it makes each test take this long.
60-
);
57+
// Disable the timeout otherwise it makes each test take this long.
58+
new CircuitBreakerOptions().setTimeout(-1));
6159

6260
configure(router);
6361
router

instrumentation/vertx/vertx-rx-java-3.5/javaagent/src/version35Test/java/io/opentelemetry/javaagent/instrumentation/vertx/reactive/server/VertxRxCircuitBreakerHttpServerTest.java

+2-4
Original file line numberDiff line numberDiff line change
@@ -54,10 +54,8 @@ public void start(Future<Void> startFuture) {
5454
CircuitBreaker.create(
5555
"my-circuit-breaker",
5656
vertx,
57-
new CircuitBreakerOptions()
58-
.setTimeout(
59-
-1) // Disable the timeout otherwise it makes each test take this long.
60-
);
57+
// Disable the timeout otherwise it makes each test take this long.
58+
new CircuitBreakerOptions().setTimeout(-1));
6159

6260
configure(router);
6361
router

0 commit comments

Comments
 (0)