Skip to content

Commit e8fb30e

Browse files
committed
r2dbc
1 parent bb0eca4 commit e8fb30e

File tree

2 files changed

+17
-1
lines changed

2 files changed

+17
-1
lines changed

instrumentation/r2dbc-1.0/library/src/test/java/io/opentelemetry/instrumentation/r2dbc/v1_0/R2dbcStatementTest.java

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55

66
package io.opentelemetry.instrumentation.r2dbc.v1_0;
77

8+
import io.opentelemetry.instrumentation.api.incubator.semconv.net.PeerServiceAttributesExtractor;
9+
import io.opentelemetry.instrumentation.api.incubator.semconv.net.PeerServiceResolver;
10+
import io.opentelemetry.instrumentation.r2dbc.v1_0.internal.R2dbcNetAttributesGetter;
811
import io.opentelemetry.instrumentation.reactor.v3_1.ContextPropagationOperator;
912
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
1013
import io.opentelemetry.instrumentation.testing.junit.LibraryInstrumentationExtension;
@@ -39,7 +42,18 @@ void stop() {
3942
@Override
4043
protected ConnectionFactory createProxyConnectionFactory(
4144
ConnectionFactoryOptions connectionFactoryOptions) {
42-
return R2dbcTelemetry.create(testing.getOpenTelemetry())
45+
// Create peer service mapping for testing
46+
java.util.Map<String, String> peerServiceMapping = new java.util.HashMap<>();
47+
peerServiceMapping.put("127.0.0.1", "test-peer-service");
48+
peerServiceMapping.put("localhost", "test-peer-service");
49+
peerServiceMapping.put("192.0.2.1", "test-peer-service");
50+
51+
return R2dbcTelemetry.builder(testing.getOpenTelemetry())
52+
.addAttributesExtractor(
53+
PeerServiceAttributesExtractor.create(
54+
R2dbcNetAttributesGetter.INSTANCE,
55+
PeerServiceResolver.create(peerServiceMapping)))
56+
.build()
4357
.wrapConnectionFactory(
4458
super.createProxyConnectionFactory(connectionFactoryOptions), connectionFactoryOptions);
4559
}

instrumentation/r2dbc-1.0/testing/src/main/java/io/opentelemetry/instrumentation/r2dbc/v1_0/AbstractR2dbcStatementTest.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_STATEMENT;
1818
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_SYSTEM;
1919
import static io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DB_USER;
20+
import static io.opentelemetry.semconv.incubating.PeerIncubatingAttributes.PEER_SERVICE;
2021
import static io.r2dbc.spi.ConnectionFactoryOptions.CONNECT_TIMEOUT;
2122
import static io.r2dbc.spi.ConnectionFactoryOptions.DATABASE;
2223
import static io.r2dbc.spi.ConnectionFactoryOptions.DRIVER;
@@ -181,6 +182,7 @@ void testQueries(Parameter parameter) {
181182
equalTo(maybeStable(DB_STATEMENT), parameter.expectedStatement),
182183
equalTo(maybeStable(DB_OPERATION), parameter.operation),
183184
equalTo(maybeStable(DB_SQL_TABLE), parameter.table),
185+
equalTo(PEER_SERVICE, "test-peer-service"),
184186
equalTo(SERVER_ADDRESS, container.getHost()),
185187
equalTo(SERVER_PORT, port)),
186188
span ->

0 commit comments

Comments
 (0)