static imports

Author: SentryMan

instrumentation/java-http-server/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/javahttpserver/JavaHttpServerInstrumentationModule.java

@@ -5,10 +5,11 @@
 
 package io.opentelemetry.javaagent.instrumentation.javahttpserver;
 
+import static java.util.Collections.singletonList;
+
 import com.google.auto.service.AutoService;
 import io.opentelemetry.javaagent.extension.instrumentation.InstrumentationModule;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
-import java.util.Collections;
 import java.util.List;
 
 @AutoService(InstrumentationModule.class)
@@ -19,6 +20,6 @@ public JavaHttpServerInstrumentationModule() {
 
   @Override
   public List<TypeInstrumentation> typeInstrumentations() {
-    return Collections.singletonList(new HttpServerInstrumentation());
+    return singletonList(new HttpServerInstrumentation());
   }
 }

instrumentation/java-http-server/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/javahttpserver/ResponseCustomizingFilter.java

@@ -11,7 +11,7 @@
 import io.opentelemetry.javaagent.bootstrap.http.HttpServerResponseCustomizerHolder;
 import java.io.IOException;
 
-class ResponseCustomizingFilter extends Filter {
+final class ResponseCustomizingFilter extends Filter {
 
   ResponseCustomizingFilter() {}
 

instrumentation/java-http-server/library/src/main/java/io/opentelemetry/instrumentation/javahttpserver/JavaHttpServerExchangeGetter.java

@@ -5,9 +5,11 @@
 
 package io.opentelemetry.instrumentation.javahttpserver;
 
+import static java.util.Collections.emptyIterator;
+import static java.util.Collections.emptyList;
+
 import com.sun.net.httpserver.HttpExchange;
 import io.opentelemetry.context.propagation.internal.ExtendedTextMapGetter;
-import java.util.Collections;
 import java.util.Iterator;
 import java.util.List;
 import javax.annotation.Nullable;
@@ -18,7 +20,7 @@ enum JavaHttpServerExchangeGetter implements ExtendedTextMapGetter<HttpExchange>
   @Override
   public Iterable<String> keys(@Nullable HttpExchange exchange) {
     if (exchange == null) {
-      return Collections.emptyList();
+      return emptyList();
     }
     return exchange.getRequestHeaders().keySet();
   }
@@ -37,10 +39,10 @@ public String get(@Nullable HttpExchange carrier, String key) {
   @Override
   public Iterator<String> getAll(@Nullable HttpExchange carrier, String key) {
     if (carrier == null) {
-      return Collections.emptyIterator();
+      return emptyIterator();
     }
 
     List<String> list = carrier.getRequestHeaders().get(key);
-    return list != null ? list.iterator() : Collections.emptyIterator();
+    return list != null ? list.iterator() : emptyIterator();
   }
 }

instrumentation/java-http-server/library/src/main/java/io/opentelemetry/instrumentation/javahttpserver/JavaHttpServerTelemetryBuilder.java

@@ -15,7 +15,6 @@
 import io.opentelemetry.instrumentation.api.semconv.http.HttpServerAttributesExtractorBuilder;
 import io.opentelemetry.instrumentation.javahttpserver.internal.Experimental;
 import io.opentelemetry.instrumentation.javahttpserver.internal.JavaHttpServerInstrumenterBuilderUtil;
-
 import java.util.Collection;
 import java.util.function.Function;
 

instrumentation/java-http-server/library/src/main/java/io/opentelemetry/instrumentation/javahttpserver/internal/Experimental.java

@@ -5,11 +5,10 @@
 
 package io.opentelemetry.instrumentation.javahttpserver.internal;
 
+import io.opentelemetry.instrumentation.javahttpserver.JavaHttpServerTelemetryBuilder;
 import java.util.function.BiConsumer;
 import javax.annotation.Nullable;
 
-import io.opentelemetry.instrumentation.javahttpserver.JavaHttpServerTelemetryBuilder;
-
 /**
  * This class is internal and experimental. Its APIs are unstable and can change at any time. Its
  * APIs (or a version of them) may be promoted to the public stable API in the future, but no

instrumentation/java-http-server/library/src/main/java/io/opentelemetry/instrumentation/javahttpserver/internal/JavaHttpServerInstrumenterBuilderUtil.java

@@ -8,7 +8,6 @@
 import com.sun.net.httpserver.HttpExchange;
 import io.opentelemetry.instrumentation.api.incubator.builder.internal.DefaultHttpServerInstrumenterBuilder;
 import io.opentelemetry.instrumentation.javahttpserver.JavaHttpServerTelemetryBuilder;
-
 import java.util.function.Function;
 import javax.annotation.Nullable;