Skip to content

Spans not being generated for RMI application. #4695

Answered by trask
Samudraneel24 asked this question in Q&A
Discussion options

You must be logged in to vote
  • As I wrote in the earlier comment, I think the condition check if (!Java8BytecodeBridge.spanFromContext(parentContext).getSpanContext().isValid()) { return; } shouldn't be there in UnicastRefInstrumentation.java. Thoughts?

Some related discussion recently: #4579 (comment)

This condition dates back to the original rmi instrumentation commit DataDog/dd-trace-java#1128, and I could not find any discussion of why it's desirable not to create a rmi client span when there's no parent.

Typically this condition would be used to limit noisy background usage. But without any further info, I would support removing the condition, and if we find that it's too noisy we can revisit and document the …

Replies: 2 comments 5 replies

Comment options

You must be logged in to vote
4 replies
@Samudraneel24
Comment options

@Samudraneel24
Comment options

@laurit
Comment options

@Samudraneel24
Comment options

Comment options

You must be logged in to vote
1 reply
@Samudraneel24
Comment options

Answer selected by Samudraneel24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
4 participants