Replies: 1 comment 1 reply
-
hey @dboreham! the if Slick has its own ExecutorService implementation, you may be able to just add that to in this case, adding a test with if not, you may need to implement something similar to the ExecutorService instrumentation but for Slick's specific classes in this case, check out https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/contributing/writing-instrumentation.md (and https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/docs/contributing/writing-instrumentation-module.md) |
Beta Was this translation helpful? Give feedback.
-
Hello, does the agent as-is automatically instrument applications using Slick? It has been reported to me that it doesn't (parent span is lost after the context switch to a thread in Slick's AsyncExecutor), however I see some Slick-related code, and a test in the agent: https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/main/instrumentation/scala-fork-join-2.8/javaagent/src/slickTest/scala/SlickUtils.scala which suggests that perhaps it is expected to work. I wondered if perhaps the agent's Scala support was developed in the past when Slick used the stock Scala ForkJoinPool and things had rotted in the meantime.
Anyway, it'd be great to hear any thoughts, pointers, etc on this before I dive in. Thanks.
Beta Was this translation helpful? Give feedback.
All reactions