Please help me with extention for SpanProcessor

[YonatanHunger]

I am trying to extend OpenTelemetry java agent and I don't see any indication it is trying to load my jar.
I am running the following cmd:

java -javaagent:../src/main/resources/opentelemetry-javaagent.jar -Dotel.javaagent.configuration-file=../src/main/resources/agent-prp.properties -jar simple-service-1.0-SNAPSHOT-jar-with-dependencies.jar

my config file is (the attributes are working):

otel.javaagent.extensions=/Users/foo/source/simple-service/src/main/resources/span-processor-1.0-SNAPSHOT.jar
otel.resource.attributes=service.name=foooBarr

my extension is:

import com.fasterxml.jackson.core.JsonProcessingException;
import com.fasterxml.jackson.databind.ObjectMapper;
import io.opentelemetry.context.Context;
import io.opentelemetry.sdk.common.CompletableResultCode;
import io.opentelemetry.sdk.trace.ReadWriteSpan;
import io.opentelemetry.sdk.trace.ReadableSpan;
import io.opentelemetry.sdk.trace.SpanProcessor;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
...

public class FooSpanProcessor implements SpanProcessor {
    private static final ObjectMapper objMapper = new ObjectMapper();
    private static final Logger log = LoggerFactory.getLogger(FooSpanProcessor.class);


    @Override
    public void onStart(Context parentContext, ReadWriteSpan span) {
        span.setAttribute("fooToken", FooProperties.INSTANCE.fooToken);
        span.setAttribute("service.name", FooProperties.INSTANCE.serviceName);
        span.setAttribute("runtime", FooProperties.INSTANCE.javaVersion);
        span.setAttribute("tracerVersion", "0.0.1");
        span.setAttribute("framework", FooProperties.INSTANCE.frameWork);
        span.setAttribute("envs", FooProperties.INSTANCE.environment);
        span.setAttribute("metaData", FooProperties.INSTANCE.metadata);
    }

    @Override
    public boolean isStartRequired() {
        return true;
    }

    @Override
    public void onEnd(ReadableSpan span) {
    }
    ....

I have added the configuration like this:

@AutoService(SdkTracerProviderConfigurer.class)
public class FooSdkTracerProviderConfigurer implements SdkTracerProviderConfigurer {
    @Override
    public void configure(SdkTracerProviderBuilder tracerProvider, ConfigProperties config) {
        tracerProvider.addSpanProcessor(new FooSpanProcessor());
    }

I don't see any indication that my extension is loaded, I don't see any of my parameters on the produced spans. can anybody help me?

[anuraaga]

Hi @YonatanHunger - due to an initialization ordering constraint, the otel.javaagent.extensions does not support being read from the properties file. Can you pass -Dotel.javaagent.extensions= on the command line and see if it helps?

[YonatanHunger]

my god, two days of my life. thank you so much!

[Yahire3388]

Hi @YonatanHunger @anuraaga ,

I am trying the same thing, i am using tomcat server and had passed java agent and its extension in bellow format :

But still the traces are not visible.
@YonatanHunger , can you please share your jar what you had created so that i can confirm if the issue is with my jar or the setenv file of tomcat.

Thankyou

[Yahire3388]

@trask ,

FYI, please refer the discussion.
Please help me to get this issue resolve.

Thanks

[trask]

hi @Yahire3388! can you create a minimal repro of your issue in a public github repository, and then open a new issue here with instructions how to reproduce the issue you are seeing?

[Yahire3388]

Hi @trask
please refer Yahire3388/extensionToJavaAgent#1 . I had created a repository with the extension code i am using and the steps i am performing to add extension.

Thanks

[trask]

thx @Yahire3388, can you create a new issue or new discussion also? it is harder for us to keep track when you comment across multiple old discussion threads, thx

[Yahire3388]

Hi @trask

Please refer #5647.
This is the new issue i had created in the discussion here.

Thankyou