Fix Cassandra target #10357
Merged
Fix Cassandra target #10357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heyams
changed the title
laurit
reviewed
Jan 31, 2024
...opentelemetry/javaagent/instrumentation/cassandra/v3_0/CassandraNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
...opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
heyams
changed the title
|
@laurit not sure it was regression. it seems to be a systematic change applied to all instrumentations. this PR 9cb1574#diff-9921147bb0390248e2779c790b1666bcfe76df343d4d743577c946ad42a0fadc |
trask
reviewed
Jan 31, 2024
...main/java/io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraSingletons.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Jan 31, 2024
.../io/opentelemetry/javaagent/instrumentation/cassandra/v4_0/CassandraAttributesExtractor.java
Show resolved
Hide resolved
trask
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
(note for others, this is related to open-telemetry/semantic-conventions#679)
laurit
reviewed
Feb 1, 2024
.../main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraAttributesExtractor.java
Outdated
Show resolved
Hide resolved
heyams
commented
Feb 1, 2024
...4/testing/src/main/java/io/opentelemetry/testing/cassandra/v4_4/AbstractCassandra44Test.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Feb 1, 2024
...n/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraNetworkAttributesGetter.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Feb 1, 2024
...4/testing/src/main/java/io/opentelemetry/testing/cassandra/v4_4/AbstractCassandra44Test.java
Outdated
Show resolved
Hide resolved
trask
reviewed
Feb 6, 2024
.../main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 12, 2024
.../main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 12, 2024
.../main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraAttributesExtractor.java
Outdated
Show resolved
Hide resolved
laurit
reviewed
Feb 12, 2024
trask
approved these changes
Feb 12, 2024
.../main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraAttributesExtractor.java
Show resolved
Hide resolved
.../main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraAttributesExtractor.java
Outdated
Show resolved
Hide resolved
.../io/opentelemetry/javaagent/instrumentation/cassandra/v3_0/CassandraAttributesExtractor.java
Show resolved
Hide resolved
.../main/java/io/opentelemetry/instrumentation/cassandra/v4_4/CassandraAttributesExtractor.java
Outdated
Show resolved
Hide resolved
...4/testing/src/main/java/io/opentelemetry/testing/cassandra/v4_4/AbstractCassandra44Test.java
Outdated
Show resolved
Hide resolved
|
locally it's all green.. will close/reopen to trigger new build. |
|
It looks like there's sporadic failures on the cassandra test now, I'm seeing 2 failures in the latest run. |
looking |
This reverts commit bc6ab22.
trask
force-pushed
the
heya/fix-cassandra-target
branch
2 times, most recently
from
23df5ac to
bce1ca4
Compare
trask
approved these changes
Feb 15, 2024
|
thanks ❤️ |
steverao
pushed a commit
to steverao/opentelemetry-java-instrumentation
that referenced
this pull request
Feb 16, 2024
Co-authored-by: Trask Stalnaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.