Skip to content

Deprecate DeclarativeConfigPropertiesBridge#19202

Merged
trask merged 7 commits into
open-telemetry:mainfrom
zeitlinger:agent/deprecate-declarative-config-properties-bridge
Jul 14, 2026
Merged

Deprecate DeclarativeConfigPropertiesBridge#19202
trask merged 7 commits into
open-telemetry:mainfrom
zeitlinger:agent/deprecate-declarative-config-properties-bridge

Conversation

@zeitlinger

Copy link
Copy Markdown
Member

Summary

  • deprecate DeclarativeConfigPropertiesBridge and DeclarativeConfigPropertiesBridgeBuilder
  • mark both deprecated APIs for removal in 3.0, matching the existing deprecation style used by ConfigPropertiesUtil
  • keep bridge coverage in place with test-only deprecated API suppressions

Why

All usages in this repository have already been migrated away from the bridge. This starts the removal cycle while the remaining downstream usages are updated separately.

Testing

  • GRADLE_USER_HOME=/tmp/gradle-home-otel-java-instr ./gradlew :declarative-config-bridge:test

Signed-off-by: Gregor Zeitlinger <gregor.zeitlinger@grafana.com>
@trask trask marked this pull request as ready for review July 14, 2026 01:07
@trask trask requested a review from a team as a code owner July 14, 2026 01:07
Copilot AI review requested due to automatic review settings July 14, 2026 01:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Deprecates the declarative configuration bridge ahead of its planned removal in 3.0.

Changes:

  • Adds deprecation annotations and migration guidance.
  • Documents the deprecation in the README and changelog.
  • Suppresses expected deprecation warnings in bridge tests.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
CHANGELOG.md Records the deprecation.
declarative-config-bridge/README.md Adds migration guidance.
DeclarativeConfigPropertiesBridge.java Deprecates the bridge implementation.
DeclarativeConfigPropertiesBridgeBuilder.java Deprecates the public builder.
DeclarativeConfigPropertiesBridgeTest.java Suppresses expected warnings.
DeclarativeConfigPropertiesBridgeBuilderTest.java Suppresses expected warnings.

@opentelemetry-pr-dashboard

Copy link
Copy Markdown

This PR has review comments. Review suggestions, whether from maintainers or automated reviewers, aren't always correct or required. Please evaluate each comment on its merits, then make sure each thread has a clear outcome.

For example, link to the commit if you applied a suggestion, explain why it wasn't applied, or ask a follow-up question.

Automation flags a PR for human review once every review thread has a reply or is marked as resolved.

Status across open PRs is visible on the pull request dashboard.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

@trask trask enabled auto-merge (squash) July 14, 2026 03:48
@trask trask merged commit d376041 into open-telemetry:main Jul 14, 2026
187 of 189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants