Skip to content

Feature Request: annotation for method timing metrics #4590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jkwatson opened this issue Nov 4, 2021 · 1 comment
Closed

Feature Request: annotation for method timing metrics #4590

jkwatson opened this issue Nov 4, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jkwatson
Copy link
Contributor

jkwatson commented Nov 4, 2021

Is your feature request related to a problem? Please describe.
Not all methods are appropriate for having spans generated for them (especially very high volume methods in an otherwise relatively low-volume request path). It would be very useful to be able to generate method-timing metrics for methods like this.

Describe the solution you'd like
Analogous to @WithSpan, something like @Timed at the method level.

Describe alternatives you've considered
Manually creating metrics would of course work, but is much more boilerplate code, especially in the absence of a top-level Timer instrument.

Open Questions
Does each of these generate a new Instrument? Or use a common instrument, and add an attribute for the method name?

@jkwatson jkwatson added the enhancement New feature or request label Nov 4, 2021
@trask
Copy link
Member

trask commented Sep 4, 2023

Closing in favor of #7030

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants