Add replicaset resources by default

Signed-off-by: Israel Blancas <[email protected]>

Author: iblancasa

internal/manifests/collector/parser/processor/processor_k8sattributes.go

@@ -50,15 +50,24 @@ func (o *K8sAttributesParser) ParserName() string {
 }
 
 func (o *K8sAttributesParser) GetRBACRules() []rbacv1.PolicyRule {
-	var prs []rbacv1.PolicyRule
-
-	// This one needs to be added always
-	policy := rbacv1.PolicyRule{
-		APIGroups: []string{""},
-		Resources: []string{"pods", "namespaces"},
-		Verbs:     []string{"get", "watch", "list"},
+	// These policies need to be added always
+	var prs []rbacv1.PolicyRule = []rbacv1.PolicyRule{
+		{
+			APIGroups: []string{""},
+			Resources: []string{"pods", "namespaces"},
+			Verbs:     []string{"get", "watch", "list"},
+		},
+		{
+			APIGroups: []string{"apps"},
+			Resources: []string{"replicasets"},
+			Verbs:     []string{"get", "watch", "list"},
+		},
+		{
+			APIGroups: []string{"extensions"},
+			Resources: []string{"replicasets"},
+			Verbs:     []string{"get", "watch", "list"},
+		},
 	}
-	prs = append(prs, policy)
 
 	extractCfg, ok := o.config["extract"]
 	if !ok {
@@ -77,20 +86,7 @@ func (o *K8sAttributesParser) GetRBACRules() []rbacv1.PolicyRule {
 
 	for _, m := range metadata {
 		metadataField := fmt.Sprint(m)
-		if metadataField == "k8s.deployment.uid" || metadataField == "k8s.deployment.name" {
-			prs = append(prs,
-				rbacv1.PolicyRule{
-					APIGroups: []string{"apps"},
-					Resources: []string{"replicasets"},
-					Verbs:     []string{"get", "watch", "list"},
-				},
-				rbacv1.PolicyRule{
-					APIGroups: []string{"extensions"},
-					Resources: []string{"replicasets"},
-					Verbs:     []string{"get", "watch", "list"},
-				},
-			)
-		} else if strings.Contains(metadataField, "k8s.node") {
+		if strings.Contains(metadataField, "k8s.node") {
 			prs = append(prs,
 				rbacv1.PolicyRule{
 					APIGroups: []string{""},

internal/manifests/collector/parser/processor/processor_k8sattributes_test.go

@@ -34,23 +34,6 @@ func TestK8sAttributesRBAC(t *testing.T) {
 		{
 			name:   "no extra parameters",
 			config: nil,
-			expectedRules: []rbacv1.PolicyRule{
-				{
-					APIGroups: []string{""},
-					Resources: []string{"pods", "namespaces"},
-					Verbs:     []string{"get", "watch", "list"},
-				},
-			},
-		},
-		{
-			name: "extract k8s.deployment.uid",
-			config: map[interface{}]interface{}{
-				"extract": map[interface{}]interface{}{
-					"metadata": []interface{}{
-						"k8s.deployment.uid",
-					},
-				},
-			},
 			expectedRules: []rbacv1.PolicyRule{
 				{
 					APIGroups: []string{""},
@@ -70,11 +53,11 @@ func TestK8sAttributesRBAC(t *testing.T) {
 			},
 		},
 		{
-			name: "extract k8s.deployment.name",
+			name: "extract k8s.node",
 			config: map[interface{}]interface{}{
 				"extract": map[interface{}]interface{}{
 					"metadata": []interface{}{
-						"k8s.deployment.name",
+						"k8s.node",
 					},
 				},
 			},
@@ -94,6 +77,11 @@ func TestK8sAttributesRBAC(t *testing.T) {
 					Resources: []string{"replicasets"},
 					Verbs:     []string{"get", "watch", "list"},
 				},
+				{
+					APIGroups: []string{""},
+					Resources: []string{"nodes"},
+					Verbs:     []string{"get", "watch", "list"},
+				},
 			},
 		},
 	}