Skip to content

Commit 0a7d640

Browse files
committed
fix select document.
1 parent fff0c2a commit 0a7d640

File tree

4 files changed

+51
-8
lines changed

4 files changed

+51
-8
lines changed

apis/v1alpha1/instrumentation_types.go

+1
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import (
2323
// InstrumentationSpec defines the desired state of OpenTelemetry SDK and instrumentation.
2424
type InstrumentationSpec struct {
2525
// Selector is the label selector for affected Pods.
26+
// This selector only takes effect when annotation: instrumentation.opentelemetry.io/inject-xx equal true.
2627
// Unlike standard label selectors, `nil` means `everything`, and this is also the default.
2728
// This may change in a future CRD version.
2829
// +optional

bundle/manifests/opentelemetry.io_instrumentations.yaml

+18
Original file line numberDiff line numberDiff line change
@@ -1677,15 +1677,32 @@ spec:
16771677
type: string
16781678
type: object
16791679
selector:
1680+
description: |-
1681+
Selector is the label selector for affected Pods.
1682+
This selector only takes effect when annotation: instrumentation.opentelemetry.io/inject-xx equal true.
16801683
properties:
16811684
matchExpressions:
1685+
description: matchExpressions is a list of label selector requirements.
1686+
The requirements are ANDed.
16821687
items:
1688+
description: |-
1689+
A label selector requirement is a selector that contains values, a key, and an operator that
1690+
relates the key and values.
16831691
properties:
16841692
key:
1693+
description: key is the label key that the selector applies
1694+
to.
16851695
type: string
16861696
operator:
1697+
description: |-
1698+
operator represents a key's relationship to a set of values.
1699+
Valid operators are In, NotIn, Exists and DoesNotExist.
16871700
type: string
16881701
values:
1702+
description: |-
1703+
values is an array of string values. If the operator is In or NotIn,
1704+
the values array must be non-empty. If the operator is Exists or DoesNotExist,
1705+
the values array must be empty.
16891706
items:
16901707
type: string
16911708
type: array
@@ -1697,6 +1714,7 @@ spec:
16971714
matchLabels:
16981715
additionalProperties:
16991716
type: string
1717+
description: matchLabels is a map of {key,value} pairs.
17001718
type: object
17011719
type: object
17021720
x-kubernetes-map-type: atomic

config/crd/bases/opentelemetry.io_instrumentations.yaml

+18
Original file line numberDiff line numberDiff line change
@@ -1675,15 +1675,32 @@ spec:
16751675
type: string
16761676
type: object
16771677
selector:
1678+
description: |-
1679+
Selector is the label selector for affected Pods.
1680+
This selector only takes effect when annotation: instrumentation.opentelemetry.io/inject-xx equal true.
16781681
properties:
16791682
matchExpressions:
1683+
description: matchExpressions is a list of label selector requirements.
1684+
The requirements are ANDed.
16801685
items:
1686+
description: |-
1687+
A label selector requirement is a selector that contains values, a key, and an operator that
1688+
relates the key and values.
16811689
properties:
16821690
key:
1691+
description: key is the label key that the selector applies
1692+
to.
16831693
type: string
16841694
operator:
1695+
description: |-
1696+
operator represents a key's relationship to a set of values.
1697+
Valid operators are In, NotIn, Exists and DoesNotExist.
16851698
type: string
16861699
values:
1700+
description: |-
1701+
values is an array of string values. If the operator is In or NotIn,
1702+
the values array must be non-empty. If the operator is Exists or DoesNotExist,
1703+
the values array must be empty.
16871704
items:
16881705
type: string
16891706
type: array
@@ -1695,6 +1712,7 @@ spec:
16951712
matchLabels:
16961713
additionalProperties:
16971714
type: string
1715+
description: matchLabels is a map of {key,value} pairs.
16981716
type: object
16991717
type: object
17001718
x-kubernetes-map-type: atomic

docs/api.md

+14-8
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,8 @@ Enum=tracecontext;baggage;b3;b3multi;jaeger;xray;ottrace;none<br/>
177177
<td><b><a href="#instrumentationspecselector">selector</a></b></td>
178178
<td>object</td>
179179
<td>
180-
<br/>
180+
Selector is the label selector for affected Pods.
181+
This selector only takes effect when annotation: instrumentation.opentelemetry.io/inject-xx equal true.<br/>
181182
</td>
182183
<td>false</td>
183184
</tr></tbody>
@@ -3767,7 +3768,8 @@ The value can be for instance parentbased_always_on, parentbased_always_off, par
37673768

37683769

37693770

3770-
3771+
Selector is the label selector for affected Pods.
3772+
This selector only takes effect when annotation: instrumentation.opentelemetry.io/inject-xx equal true.
37713773

37723774
<table>
37733775
<thead>
@@ -3782,14 +3784,14 @@ The value can be for instance parentbased_always_on, parentbased_always_off, par
37823784
<td><b><a href="#instrumentationspecselectormatchexpressionsindex">matchExpressions</a></b></td>
37833785
<td>[]object</td>
37843786
<td>
3785-
<br/>
3787+
matchExpressions is a list of label selector requirements. The requirements are ANDed.<br/>
37863788
</td>
37873789
<td>false</td>
37883790
</tr><tr>
37893791
<td><b>matchLabels</b></td>
37903792
<td>map[string]string</td>
37913793
<td>
3792-
<br/>
3794+
matchLabels is a map of {key,value} pairs.<br/>
37933795
</td>
37943796
<td>false</td>
37953797
</tr></tbody>
@@ -3801,7 +3803,8 @@ The value can be for instance parentbased_always_on, parentbased_always_off, par
38013803

38023804

38033805

3804-
3806+
A label selector requirement is a selector that contains values, a key, and an operator that
3807+
relates the key and values.
38053808

38063809
<table>
38073810
<thead>
@@ -3816,21 +3819,24 @@ The value can be for instance parentbased_always_on, parentbased_always_off, par
38163819
<td><b>key</b></td>
38173820
<td>string</td>
38183821
<td>
3819-
<br/>
3822+
key is the label key that the selector applies to.<br/>
38203823
</td>
38213824
<td>true</td>
38223825
</tr><tr>
38233826
<td><b>operator</b></td>
38243827
<td>string</td>
38253828
<td>
3826-
<br/>
3829+
operator represents a key's relationship to a set of values.
3830+
Valid operators are In, NotIn, Exists and DoesNotExist.<br/>
38273831
</td>
38283832
<td>true</td>
38293833
</tr><tr>
38303834
<td><b>values</b></td>
38313835
<td>[]string</td>
38323836
<td>
3833-
<br/>
3837+
values is an array of string values. If the operator is In or NotIn,
3838+
the values array must be non-empty. If the operator is Exists or DoesNotExist,
3839+
the values array must be empty.<br/>
38343840
</td>
38353841
<td>false</td>
38363842
</tr></tbody>

0 commit comments

Comments
 (0)