Skip to content

Commit 1980f08

Browse files
authored
[chore] unexport type (#3636)
1 parent 314df7b commit 1980f08

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

internal/openshift/dashboards/dashboards.go

+6-5
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ import (
2222
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2323
v1 "k8s.io/apimachinery/pkg/apis/meta/v1"
2424
"k8s.io/client-go/kubernetes"
25+
"sigs.k8s.io/controller-runtime/pkg/manager"
2526
)
2627

2728
// The dashboard is created manually following the syntax from Grafana 5. For development purposes, this dashboard can be created just by loading the JSON file
@@ -35,17 +36,17 @@ const (
3536
configMapName = "opentelemetry-collector"
3637
)
3738

38-
type DashboardManagement struct {
39+
type dashboardManagement struct {
3940
clientset kubernetes.Interface
4041
}
4142

42-
func NewDashboardManagement(clientset kubernetes.Interface) DashboardManagement {
43-
return DashboardManagement{
43+
func NewDashboardManagement(clientset kubernetes.Interface) manager.Runnable {
44+
return dashboardManagement{
4445
clientset: clientset,
4546
}
4647
}
4748

48-
func (d DashboardManagement) Start(ctx context.Context) error {
49+
func (d dashboardManagement) Start(ctx context.Context) error {
4950
cm := corev1.ConfigMap{
5051
ObjectMeta: v1.ObjectMeta{
5152
Name: configMapName,
@@ -69,6 +70,6 @@ func (d DashboardManagement) Start(ctx context.Context) error {
6970
return d.clientset.CoreV1().ConfigMaps(openshiftDashboardsNamespace).Delete(ctx, configMapName, metav1.DeleteOptions{})
7071
}
7172

72-
func (d DashboardManagement) NeedLeaderElection() bool {
73+
func (d dashboardManagement) NeedLeaderElection() bool {
7374
return true
7475
}

0 commit comments

Comments
 (0)