Skip to content

Commit 1b95647

Browse files
committed
Fix
Signed-off-by: Pavol Loffay <[email protected]>
1 parent 4226f74 commit 1b95647

File tree

3 files changed

+1
-65
lines changed

3 files changed

+1
-65
lines changed

apis/v1beta1/collector_webhook.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ package v1beta1
1717
import (
1818
"context"
1919
"fmt"
20-
ta "github.com/open-telemetry/opentelemetry-operator/internal/manifests/targetallocator/adapters"
2120
"strings"
2221

2322
"github.com/go-logr/logr"
@@ -31,7 +30,7 @@ import (
3130
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"
3231

3332
"github.com/open-telemetry/opentelemetry-operator/internal/config"
34-
//ta "github.com/open-telemetry/opentelemetry-operator/internal/manifests/targetallocator/adapters"
33+
ta "github.com/open-telemetry/opentelemetry-operator/internal/manifests/targetallocator/adapters"
3534
"github.com/open-telemetry/opentelemetry-operator/internal/rbac"
3635
)
3736

config/webhook/manifests.yaml

-59
Original file line numberDiff line numberDiff line change
@@ -64,26 +64,6 @@ webhooks:
6464
resources:
6565
- opampbridges
6666
sideEffects: None
67-
- admissionReviewVersions:
68-
- v1
69-
clientConfig:
70-
service:
71-
name: webhook-service
72-
namespace: system
73-
path: /mutate-opentelemetry-io-v1alpha1-opentelemetrycollector
74-
failurePolicy: Fail
75-
name: mopentelemetrycollector.kb.io
76-
rules:
77-
- apiGroups:
78-
- opentelemetry.io
79-
apiVersions:
80-
- v1alpha1
81-
operations:
82-
- CREATE
83-
- UPDATE
84-
resources:
85-
- opentelemetrycollectors
86-
sideEffects: None
8767
- admissionReviewVersions:
8868
- v1
8969
clientConfig:
@@ -226,42 +206,3 @@ webhooks:
226206
resources:
227207
- opampbridges
228208
sideEffects: None
229-
- admissionReviewVersions:
230-
- v1
231-
clientConfig:
232-
service:
233-
name: webhook-service
234-
namespace: system
235-
path: /validate-opentelemetry-io-v1alpha1-opentelemetrycollector
236-
failurePolicy: Fail
237-
name: vopentelemetrycollectorcreateupdate.kb.io
238-
rules:
239-
- apiGroups:
240-
- opentelemetry.io
241-
apiVersions:
242-
- v1alpha1
243-
operations:
244-
- CREATE
245-
- UPDATE
246-
resources:
247-
- opentelemetrycollectors
248-
sideEffects: None
249-
- admissionReviewVersions:
250-
- v1
251-
clientConfig:
252-
service:
253-
name: webhook-service
254-
namespace: system
255-
path: /validate-opentelemetry-io-v1alpha1-opentelemetrycollector
256-
failurePolicy: Ignore
257-
name: vopentelemetrycollectordelete.kb.io
258-
rules:
259-
- apiGroups:
260-
- opentelemetry.io
261-
apiVersions:
262-
- v1alpha1
263-
operations:
264-
- DELETE
265-
resources:
266-
- opentelemetrycollectors
267-
sideEffects: None

controllers/suite_test.go

-4
Original file line numberDiff line numberDiff line change
@@ -166,10 +166,6 @@ func TestMain(m *testing.M) {
166166
}
167167
reviewer := rbac.NewReviewer(clientset)
168168

169-
//if err = v1alpha1.SetupCollectorWebhook(mgr, config.New(), reviewer); err != nil {
170-
// fmt.Printf("failed to SetupWebhookWithManager: %v", err)
171-
// os.Exit(1)
172-
//}
173169
if err = v1beta1.SetupCollectorWebhook(mgr, config.New(), reviewer); err != nil {
174170
fmt.Printf("failed to SetupWebhookWithManager: %v", err)
175171
os.Exit(1)

0 commit comments

Comments
 (0)