Skip to content

Commit 1bdf863

Browse files
committed
test: use utilruntime package wrap AddToScheme method
1 parent 78e7c2f commit 1bdf863

File tree

5 files changed

+17
-45
lines changed

5 files changed

+17
-45
lines changed

controllers/suite_test.go

+7-20
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ import (
3636
"k8s.io/apimachinery/pkg/runtime"
3737
"k8s.io/apimachinery/pkg/types"
3838
"k8s.io/apimachinery/pkg/util/intstr"
39+
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
3940
"k8s.io/apimachinery/pkg/util/uuid"
4041
"k8s.io/apimachinery/pkg/util/wait"
4142
"k8s.io/client-go/kubernetes"
@@ -109,26 +110,12 @@ func TestMain(m *testing.M) {
109110
fmt.Printf("failed to start testEnv: %v", err)
110111
os.Exit(1)
111112
}
112-
if err = monitoringv1.AddToScheme(testScheme); err != nil {
113-
fmt.Printf("failed to register scheme: %v", err)
114-
os.Exit(1)
115-
}
116-
if err = networkingv1.AddToScheme(testScheme); err != nil {
117-
fmt.Printf("failed to register scheme: %v", err)
118-
os.Exit(1)
119-
}
120-
if err = routev1.AddToScheme(testScheme); err != nil {
121-
fmt.Printf("failed to register scheme: %v", err)
122-
os.Exit(1)
123-
}
124-
if err = v1alpha1.AddToScheme(testScheme); err != nil {
125-
fmt.Printf("failed to register scheme: %v", err)
126-
os.Exit(1)
127-
}
128-
if err = v1beta1.AddToScheme(testScheme); err != nil {
129-
fmt.Printf("failed to register scheme: %v", err)
130-
os.Exit(1)
131-
}
113+
114+
utilruntime.Must(monitoringv1.AddToScheme(testScheme))
115+
utilruntime.Must(networkingv1.AddToScheme(testScheme))
116+
utilruntime.Must(routev1.AddToScheme(testScheme))
117+
utilruntime.Must(v1alpha1.AddToScheme(testScheme))
118+
utilruntime.Must(v1beta1.AddToScheme(testScheme))
132119

133120
testEnv = &envtest.Environment{
134121
CRDDirectoryPaths: []string{filepath.Join("..", "config", "crd", "bases")},

internal/webhook/podmutation/webhookhandler_suite_test.go

+3-8
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
"time"
2727

2828
"k8s.io/apimachinery/pkg/runtime"
29+
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
2930
"k8s.io/apimachinery/pkg/util/wait"
3031
"k8s.io/client-go/kubernetes"
3132
"k8s.io/client-go/kubernetes/scheme"
@@ -57,14 +58,8 @@ var (
5758
func TestMain(m *testing.M) {
5859
ctx, cancel = context.WithCancel(context.TODO())
5960
defer cancel()
60-
if err = v1alpha1.AddToScheme(testScheme); err != nil {
61-
fmt.Printf("failed to register scheme: %v", err)
62-
os.Exit(1)
63-
}
64-
if err = v1beta1.AddToScheme(testScheme); err != nil {
65-
fmt.Printf("failed to register scheme: %v", err)
66-
os.Exit(1)
67-
}
61+
utilruntime.Must(v1alpha1.AddToScheme(testScheme))
62+
utilruntime.Must(v1beta1.AddToScheme(testScheme))
6863

6964
testEnv = &envtest.Environment{
7065
CRDDirectoryPaths: []string{filepath.Join("..", "..", "..", "config", "crd", "bases")},

pkg/collector/upgrade/suite_test.go

+3-9
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ import (
2626
"time"
2727

2828
"k8s.io/apimachinery/pkg/runtime"
29+
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
2930
"k8s.io/apimachinery/pkg/util/wait"
3031
"k8s.io/client-go/kubernetes"
3132
"k8s.io/client-go/kubernetes/scheme"
@@ -57,15 +58,8 @@ var (
5758
func TestMain(m *testing.M) {
5859
ctx, cancel = context.WithCancel(context.TODO())
5960
defer cancel()
60-
61-
if err = v1alpha1.AddToScheme(testScheme); err != nil {
62-
fmt.Printf("failed to register scheme: %v", err)
63-
os.Exit(1)
64-
}
65-
if err = v1beta1.AddToScheme(testScheme); err != nil {
66-
fmt.Printf("failed to register scheme: %v", err)
67-
os.Exit(1)
68-
}
61+
utilruntime.Must(v1alpha1.AddToScheme(testScheme))
62+
utilruntime.Must(v1beta1.AddToScheme(testScheme))
6963

7064
testEnv = &envtest.Environment{
7165
CRDDirectoryPaths: []string{filepath.Join("..", "..", "..", "config", "crd", "bases")},

pkg/instrumentation/instrumentation_suite_test.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"path/filepath"
2121
"testing"
2222

23+
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
2324
"k8s.io/client-go/kubernetes/scheme"
2425
"k8s.io/client-go/rest"
2526
"sigs.k8s.io/controller-runtime/pkg/client"
@@ -47,10 +48,7 @@ func TestMain(m *testing.M) {
4748
os.Exit(1)
4849
}
4950

50-
if err = v1alpha1.AddToScheme(testScheme); err != nil {
51-
fmt.Printf("failed to register scheme: %v", err)
52-
os.Exit(1)
53-
}
51+
utilruntime.Must(v1alpha1.AddToScheme(testScheme))
5452

5553
k8sClient, err = client.New(cfg, client.Options{Scheme: testScheme})
5654
if err != nil {

pkg/instrumentation/upgrade/upgrade_suite_test.go

+2-4
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ import (
2020
"path/filepath"
2121
"testing"
2222

23+
utilruntime "k8s.io/apimachinery/pkg/util/runtime"
2324
"k8s.io/client-go/kubernetes/scheme"
2425
"k8s.io/client-go/rest"
2526
"sigs.k8s.io/controller-runtime/pkg/client"
@@ -47,10 +48,7 @@ func TestMain(m *testing.M) {
4748
os.Exit(1)
4849
}
4950

50-
if err = v1alpha1.AddToScheme(testScheme); err != nil {
51-
fmt.Printf("failed to register scheme: %v", err)
52-
os.Exit(1)
53-
}
51+
utilruntime.Must(v1alpha1.AddToScheme(testScheme))
5452

5553
k8sClient, err = client.New(cfg, client.Options{Scheme: testScheme})
5654
if err != nil {

0 commit comments

Comments
 (0)