Minor fixes

Author: ItielOlenick

go.mod

@@ -50,11 +50,10 @@ require (
 	k8s.io/kubectl v0.31.1
 	k8s.io/utils v0.0.0-20240711033017-18e509b52bc8
 	sigs.k8s.io/controller-runtime v0.19.0
+	sigs.k8s.io/gateway-api v1.0.0 // indirect
 	sigs.k8s.io/yaml v1.4.0
 )
 
-require sigs.k8s.io/gateway-api v1.0.0 // indirect
-
 require (
 	cloud.google.com/go/auth v0.7.0 // indirect
 	cloud.google.com/go/auth/oauth2adapt v0.2.2 // indirect

internal/manifests/targetallocator/adapters/config_to_prom_config_test.go

@@ -539,7 +539,6 @@ func TestAddTAConfigToPromConfigWithTLSConfig(t *testing.T) {
 		}
 
 		taServiceName := "test-targetallocator"
-		taServiceNamespace := "default"
 
 		expectedResult := map[interface{}]interface{}{
 			"config": map[interface{}]interface{}{},
@@ -555,7 +554,7 @@ func TestAddTAConfigToPromConfigWithTLSConfig(t *testing.T) {
 			},
 		}
 
-		result, err := ta.AddTAConfigToPromConfig(cfg, taServiceName, taServiceNamespace, ta.WithTLSConfig("ca.crt", "tls.crt", "tls.key", taServiceName))
+		result, err := ta.AddTAConfigToPromConfig(cfg, taServiceName, ta.WithTLSConfig("ca.crt", "tls.crt", "tls.key", taServiceName))
 
 		assert.NoError(t, err)
 		assert.Equal(t, expectedResult, result)

internal/manifests/targetallocator/targetallocator.go

@@ -48,11 +48,13 @@ func Build(params Params) ([]client.Object, error) {
 	}
 
 	if params.Config.CertManagerAvailability() == certmanager.Available && featuregate.EnableTargetAllocatorMTLS.IsEnabled() {
-		resourceFactories = append(resourceFactories, manifests.FactoryWithoutError(SelfSignedIssuer))
-		resourceFactories = append(resourceFactories, manifests.FactoryWithoutError(CACertificate))
-		resourceFactories = append(resourceFactories, manifests.FactoryWithoutError(CAIssuer))
-		resourceFactories = append(resourceFactories, manifests.FactoryWithoutError(ServingCertificate))
-		resourceFactories = append(resourceFactories, manifests.FactoryWithoutError(ClientCertificate))
+		resourceFactories = append(resourceFactories,
+			manifests.FactoryWithoutError(SelfSignedIssuer),
+			manifests.FactoryWithoutError(CACertificate),
+			manifests.FactoryWithoutError(CAIssuer),
+			manifests.FactoryWithoutError(ServingCertificate),
+			manifests.FactoryWithoutError(ClientCertificate),
+		)
 	}
 
 	for _, factory := range resourceFactories {