fix: exporter panic on malformed endpoint configuration

dexter0195 · dexter0195 · commit 3bb5fdffabfb · 2024-02-21T08:37:11.000+01:00
diff --git a/internal/manifests/collector/parser/exporter/exporter_prometheus.go b/internal/manifests/collector/parser/exporter/exporter_prometheus.go
@@ -59,9 +59,9 @@ func (o *PrometheusExporterParser) Ports() ([]corev1.ServicePort, error) {
 			},
 		)
 	} else {
-		ports = append(
-			ports, *singlePortFromConfigEndpoint(o.logger, o.name, o.config),
-		)
+		if port := singlePortFromConfigEndpoint(o.logger, o.name, o.config); port != nil {
+			ports = append(ports, *port)
+		}
 	}
 
 	return ports, nil

Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,9 @@ func (o *PrometheusExporterParser) Ports() ([]corev1.ServicePort, error) {`
`59`	`59`	`},`
`60`	`60`	`)`
`61`	`61`	`} else {`
`62`		`- ports = append(`
`63`		`- ports, *singlePortFromConfigEndpoint(o.logger, o.name, o.config),`
`64`		`- )`
	`62`	`+ if port := singlePortFromConfigEndpoint(o.logger, o.name, o.config); port != nil {`
	`63`	`+ ports = append(ports, *port)`
	`64`	`+ }`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`return ports, nil`