Skip to content

Commit 5b4ff61

Browse files
Merge branch 'main' into rashmi/keepequal-fix
2 parents b8b4023 + a3919b9 commit 5b4ff61

12 files changed

+3378
-688
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
2+
change_type: bug_fix
3+
4+
# The name of the component, or a single word describing the area of concern, (e.g. operator, target allocator, github action)
5+
component: documentation
6+
7+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
8+
note: The description for some fields was truncated in the documentation.
9+
10+
# One or more tracking issues related to the change
11+
issues: [2563]
12+
13+
# (Optional) One or more lines of additional information to render under the primary note.
14+
# These lines will be padded with 2 spaces and then inserted directly into the document.
15+
# Use pipe (|) for multiline entries.
16+
subtext:

.chloggen/support-extensions.yaml

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
2+
change_type: enhancement
3+
4+
# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action)
5+
component: auto-instrumentation
6+
7+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
8+
note: Support Java auto-instrumentation extensions.
9+
10+
# One or more tracking issues related to the change
11+
issues: [1785]
12+
13+
# (Optional) One or more lines of additional information to render under the primary note.
14+
# These lines will be padded with 2 spaces and then inserted directly into the document.
15+
# Use pipe (|) for multiline entries.
16+
subtext:

Makefile

+5-2
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ release-artifacts: set-image-controller
171171
# Generate manifests e.g. CRD, RBAC etc.
172172
.PHONY: manifests
173173
manifests: controller-gen
174-
$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=config/crd/bases
174+
$(CONTROLLER_GEN) $(CRD_OPTIONS) rbac:roleName=manager-role webhook paths="./..." output:crd:artifacts:config=$(MANIFEST_DIR)
175175

176176
# Run tests
177177
# setup-envtest uses KUBEBUILDER_ASSETS which points to a directory with binaries (api-server, etcd and kubectl)
@@ -475,8 +475,11 @@ bundle-push:
475475
api-docs: crdoc kustomize
476476
@{ \
477477
set -e ;\
478+
TMP_MANIFEST_DIR=$$(mktemp -d) ; \
479+
cp -r config/crd/* $$TMP_MANIFEST_DIR; \
480+
$(MAKE) CRD_OPTIONS=$(CRD_OPTIONS),maxDescLen=1200 MANIFEST_DIR=$$TMP_MANIFEST_DIR/bases manifests ;\
478481
TMP_DIR=$$(mktemp -d) ; \
479-
$(KUSTOMIZE) build config/crd -o $$TMP_DIR/crd-output.yaml ;\
482+
$(KUSTOMIZE) build $$TMP_MANIFEST_DIR -o $$TMP_DIR/crd-output.yaml ;\
480483
$(CRDOC) --resources $$TMP_DIR/crd-output.yaml --output docs/api.md ;\
481484
}
482485

apis/v1alpha1/instrumentation_types.go

+13
Original file line numberDiff line numberDiff line change
@@ -133,6 +133,19 @@ type Java struct {
133133
// Resources describes the compute resource requirements.
134134
// +optional
135135
Resources corev1.ResourceRequirements `json:"resources,omitempty"`
136+
137+
// Extensions defines java specific extensions.
138+
// All extensions are copied to a single directory; if a JAR with the same name exists, it will be overwritten.
139+
// +optional
140+
Extensions []Extensions `json:"extensions,omitempty"`
141+
}
142+
143+
type Extensions struct {
144+
// Image is a container image with extensions auto-instrumentation JAR.
145+
Image string `json:"image"`
146+
147+
// Dir is a directory with extensions auto-instrumentation JAR.
148+
Dir string `json:"dir"`
136149
}
137150

138151
// NodeJS defines NodeJS SDK and instrumentation configuration.

apis/v1alpha1/zz_generated.deepcopy.go

+20
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

bundle/manifests/opentelemetry.io_instrumentations.yaml

+19
Original file line numberDiff line numberDiff line change
@@ -919,6 +919,25 @@ spec:
919919
- name
920920
type: object
921921
type: array
922+
extensions:
923+
description: |-
924+
Extensions defines java specific extensions.
925+
All extensions are copied to a single directory; if a JAR with the same name exists, it will be overwritten.
926+
items:
927+
properties:
928+
dir:
929+
description: Dir is a directory with extensions auto-instrumentation
930+
JAR.
931+
type: string
932+
image:
933+
description: Image is a container image with extensions
934+
auto-instrumentation JAR.
935+
type: string
936+
required:
937+
- dir
938+
- image
939+
type: object
940+
type: array
922941
image:
923942
description: Image is a container image with javaagent auto-instrumentation
924943
JAR.

config/crd/bases/opentelemetry.io_instrumentations.yaml

+19
Original file line numberDiff line numberDiff line change
@@ -917,6 +917,25 @@ spec:
917917
- name
918918
type: object
919919
type: array
920+
extensions:
921+
description: |-
922+
Extensions defines java specific extensions.
923+
All extensions are copied to a single directory; if a JAR with the same name exists, it will be overwritten.
924+
items:
925+
properties:
926+
dir:
927+
description: Dir is a directory with extensions auto-instrumentation
928+
JAR.
929+
type: string
930+
image:
931+
description: Image is a container image with extensions
932+
auto-instrumentation JAR.
933+
type: string
934+
required:
935+
- dir
936+
- image
937+
type: object
938+
type: array
920939
image:
921940
description: Image is a container image with javaagent auto-instrumentation
922941
JAR.

0 commit comments

Comments
 (0)