Add replicaset resources by default when using the k8sattributesprocessor (#2832)

* Add replicaset resources by default

Signed-off-by: Israel Blancas <[email protected]>

* Add missing changelog

Signed-off-by: Israel Blancas <[email protected]>

* Fix changelog

Signed-off-by: Israel Blancas <[email protected]>

* Remove not needed permissions

Signed-off-by: Israel Blancas <[email protected]>

---------

Signed-off-by: Israel Blancas <[email protected]>

Author: iblancasa

.chloggen/bug_2823.yaml

@@ -0,0 +1,16 @@
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: bug_fix
+
+# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action)
+component: collector
+
+# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: "Create automatically the RBAC permissions to manage replicasets when using the k8sattributesprocessor"
+
+# One or more tracking issues related to the change
+issues: [2823]
+
+# (Optional) One or more lines of additional information to render under the primary note.
+# These lines will be padded with 2 spaces and then inserted directly into the document.
+# Use pipe (|) for multiline entries.
+subtext:

internal/manifests/collector/parser/processor/processor_k8sattributes.go

@@ -50,15 +50,19 @@ func (o *K8sAttributesParser) ParserName() string {
 }
 
 func (o *K8sAttributesParser) GetRBACRules() []rbacv1.PolicyRule {
-	var prs []rbacv1.PolicyRule
-
-	// This one needs to be added always
-	policy := rbacv1.PolicyRule{
-		APIGroups: []string{""},
-		Resources: []string{"pods", "namespaces"},
-		Verbs:     []string{"get", "watch", "list"},
+	// These policies need to be added always
+	var prs []rbacv1.PolicyRule = []rbacv1.PolicyRule{
+		{
+			APIGroups: []string{""},
+			Resources: []string{"pods", "namespaces"},
+			Verbs:     []string{"get", "watch", "list"},
+		},
+		{
+			APIGroups: []string{"apps"},
+			Resources: []string{"replicasets"},
+			Verbs:     []string{"get", "watch", "list"},
+		},
 	}
-	prs = append(prs, policy)
 
 	extractCfg, ok := o.config["extract"]
 	if !ok {
@@ -77,20 +81,7 @@ func (o *K8sAttributesParser) GetRBACRules() []rbacv1.PolicyRule {
 
 	for _, m := range metadata {
 		metadataField := fmt.Sprint(m)
-		if metadataField == "k8s.deployment.uid" || metadataField == "k8s.deployment.name" {
-			prs = append(prs,
-				rbacv1.PolicyRule{
-					APIGroups: []string{"apps"},
-					Resources: []string{"replicasets"},
-					Verbs:     []string{"get", "watch", "list"},
-				},
-				rbacv1.PolicyRule{
-					APIGroups: []string{"extensions"},
-					Resources: []string{"replicasets"},
-					Verbs:     []string{"get", "watch", "list"},
-				},
-			)
-		} else if strings.Contains(metadataField, "k8s.node") {
+		if strings.Contains(metadataField, "k8s.node") {
 			prs = append(prs,
 				rbacv1.PolicyRule{
 					APIGroups: []string{""},

internal/manifests/collector/parser/processor/processor_k8sattributes_test.go

@@ -34,23 +34,6 @@ func TestK8sAttributesRBAC(t *testing.T) {
 		{
 			name:   "no extra parameters",
 			config: nil,
-			expectedRules: []rbacv1.PolicyRule{
-				{
-					APIGroups: []string{""},
-					Resources: []string{"pods", "namespaces"},
-					Verbs:     []string{"get", "watch", "list"},
-				},
-			},
-		},
-		{
-			name: "extract k8s.deployment.uid",
-			config: map[interface{}]interface{}{
-				"extract": map[interface{}]interface{}{
-					"metadata": []interface{}{
-						"k8s.deployment.uid",
-					},
-				},
-			},
 			expectedRules: []rbacv1.PolicyRule{
 				{
 					APIGroups: []string{""},
@@ -62,19 +45,14 @@ func TestK8sAttributesRBAC(t *testing.T) {
 					Resources: []string{"replicasets"},
 					Verbs:     []string{"get", "watch", "list"},
 				},
-				{
-					APIGroups: []string{"extensions"},
-					Resources: []string{"replicasets"},
-					Verbs:     []string{"get", "watch", "list"},
-				},
 			},
 		},
 		{
-			name: "extract k8s.deployment.name",
+			name: "extract k8s.node",
 			config: map[interface{}]interface{}{
 				"extract": map[interface{}]interface{}{
 					"metadata": []interface{}{
-						"k8s.deployment.name",
+						"k8s.node",
 					},
 				},
 			},
@@ -90,8 +68,8 @@ func TestK8sAttributesRBAC(t *testing.T) {
 					Verbs:     []string{"get", "watch", "list"},
 				},
 				{
-					APIGroups: []string{"extensions"},
-					Resources: []string{"replicasets"},
+					APIGroups: []string{""},
+					Resources: []string{"nodes"},
 					Verbs:     []string{"get", "watch", "list"},
 				},
 			},