Skip to content

Commit c409883

Browse files
authored
Merge branch 'main' into patch-1
2 parents c51f24b + 8af4383 commit c409883

File tree

2 files changed

+19
-3
lines changed

2 files changed

+19
-3
lines changed

.chloggen/container-names.yaml

+16
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
2+
change_type: bug_fix
3+
4+
# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action)
5+
component: auto-instrumentation
6+
7+
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
8+
note: Fix ApacheHttpd, Nginx and SDK injectors to honour their container-names annotations.
9+
10+
# One or more tracking issues related to the change
11+
issues: [3313]
12+
13+
# (Optional) One or more lines of additional information to render under the primary note.
14+
# These lines will be padded with 2 spaces and then inserted directly into the document.
15+
# Use pipe (|) for multiline entries.
16+
subtext: This is a breaking change if anyone is accidentally using the enablement flag with container names for these 3 injectors.

pkg/instrumentation/podmutator.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -232,15 +232,15 @@ func (langInsts *languageInstrumentations) setLanguageSpecificContainers(ns meta
232232
},
233233
{
234234
iwc: &langInsts.ApacheHttpd,
235-
annotation: annotationInjectApacheHttpd,
235+
annotation: annotationInjectApacheHttpdContainersName,
236236
},
237237
{
238238
iwc: &langInsts.Nginx,
239-
annotation: annotationInjectNginx,
239+
annotation: annotationInjectNginxContainersName,
240240
},
241241
{
242242
iwc: &langInsts.Sdk,
243-
annotation: annotationInjectSdk,
243+
annotation: annotationInjectSdkContainersName,
244244
},
245245
}
246246

0 commit comments

Comments
 (0)