Skip to content

Commit c56078f

Browse files
committed
Fix lint
Signed-off-by: Pavol Loffay <[email protected]>
1 parent 6f0ba77 commit c56078f

File tree

4 files changed

+4
-14
lines changed

4 files changed

+4
-14
lines changed

apis/v1alpha1/convert.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -181,7 +181,7 @@ func tov1beta1TA(in OpenTelemetryTargetAllocator) v1beta1.TargetAllocatorEmbedde
181181
}
182182
}
183183

184-
// The conversion takes into account deprecated v1alpha1 spec.minReplicas and spec.maxReplicas
184+
// The conversion takes into account deprecated v1alpha1 spec.minReplicas and spec.maxReplicas.
185185
func tov1beta1Autoscaler(in *AutoscalerSpec, minReplicas, maxReplicas *int32) *v1beta1.AutoscalerSpec {
186186
if in == nil && minReplicas == nil && maxReplicas == nil {
187187
return nil

pkg/collector/upgrade/v0_38_0_test.go

+1-10
Original file line numberDiff line numberDiff line change
@@ -4,16 +4,7 @@
44
// you may not use this file except in compliance with the License.
55
// You may obtain a copy of the License at
66
//
7-
// // TESTCASE 1: verify logging args exist and no config logging parameters
8-
// // EXPECTED: drop logging args and configure logging parameters into config from args
9-
// up := &upgrade.VersionUpgrade{
10-
// Log: logger,
11-
// Version: version.Get(),
12-
// Client: nil,
13-
// Recorder: record.NewFakeRecorder(upgrade.RecordBufferSize),
14-
// }
15-
// res, err := up.ManagedInstance(context.Background(), existing)
16-
// assert.NoError(t, err)
7+
// http://www.apache.org/licenses/LICENSE-2.0
178
//
189
// Unless required by applicable law or agreed to in writing, software
1910
// distributed under the License is distributed on an "AS IS" BASIS,

pkg/collector/upgrade/v0_9_0.go

+1-2
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,10 @@ import (
1919
"strings"
2020

2121
"gopkg.in/yaml.v2"
22+
corev1 "k8s.io/api/core/v1"
2223

2324
"github.com/open-telemetry/opentelemetry-operator/apis/v1alpha1"
2425
"github.com/open-telemetry/opentelemetry-operator/internal/manifests/collector/adapters"
25-
26-
corev1 "k8s.io/api/core/v1"
2726
)
2827

2928
func upgrade0_9_0(u VersionUpgrade, otelcol *v1alpha1.OpenTelemetryCollector) (*v1alpha1.OpenTelemetryCollector, error) {

pkg/collector/upgrade/versions.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ type upgradeFunc func(u VersionUpgrade, otelcol *v1alpha1.OpenTelemetryCollector
2626
type upgradeFuncV1beta1 func(u VersionUpgrade, otelcol *v1beta1.OpenTelemetryCollector) (*v1beta1.OpenTelemetryCollector, error)
2727

2828
type otelcolVersion struct {
29-
// deprecated use upgradeV1beta1
29+
// deprecated use upgradeV1beta1.
3030
upgrade upgradeFunc
3131
upgradeV1beta1 upgradeFuncV1beta1
3232
semver.Version

0 commit comments

Comments
 (0)