Code Review fixes

Author: swiatekm

controllers/targetallocator_controller.go

@@ -91,9 +91,10 @@ func NewTargetAllocatorReconciler(
 // // +kubebuilder:rbac:groups=apps,resources=deployments,verbs=get;list;watch;create;update;patch;delete
 // // +kubebuilder:rbac:groups=policy,resources=poddisruptionbudgets,verbs=get;list;watch;create;update;patch;delete
 // // +kubebuilder:rbac:groups=monitoring.coreos.com,resources=servicemonitors;podmonitors,verbs=get;list;watch;create;update;patch;delete
-// // +kubebuilder:rbac:groups=opentelemetry.io,resources=opentelemetrycollectors,verbs=get;list;watch;update;patch
-// // +kubebuilder:rbac:groups=opentelemetry.io,resources=targetallocators,verbs=get;list;watch;update;patch
+// // +kubebuilder:rbac:groups=opentelemetry.io,resources=opentelemetrycollectors,verbs=get;list;watch
+// // +kubebuilder:rbac:groups=opentelemetry.io,resources=targetallocators,verbs=get;list;watch
 // // +kubebuilder:rbac:groups=opentelemetry.io,resources=targetallocators/status,verbs=get;update;patch
+// // +kubebuilder:rbac:groups=opentelemetry.io,resources=targetallocators/finalizers,verbs=get;update;patch
 
 // Reconcile the current state of a TargetAllocator resource with the desired state.
 func (r *TargetAllocatorReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.Result, error) {

controllers/targetallocator_controller_test.go

@@ -35,7 +35,7 @@ import (
 	"github.com/open-telemetry/opentelemetry-operator/internal/config"
 )
 
-var testLogger = logf.Log.WithName("opamp-bridge-controller-unit-tests")
+var testLogger = logf.Log.WithName("target-allocator-controller-unit-tests")
 
 func TestNewObjectsOnReconciliation_TargetAllocator(t *testing.T) {
 	// prepare

internal/status/targetallocator/targetallocator.go

@@ -24,6 +24,7 @@ import (
 )
 
 func UpdateTargetAllocatorStatus(ctx context.Context, cli client.Client, changed *v1alpha1.TargetAllocator) error {
+	// TODO: We'd like to show connected collector instances here
 	if changed.Status.Version == "" {
 		changed.Status.Version = version.TargetAllocator()
 	}