Skip to content

Commit d83ead8

Browse files
author
Israel Blancas
committed
Apply changes requested in code review
Signed-off-by: Israel Blancas <[email protected]>
1 parent f95e6e4 commit d83ead8

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

.chloggen/3149-add-must-gather.yaml

+11-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
change_type: enhancement
33

44
# The name of the component, or a single word describing the area of concern, (e.g. collector, target allocator, auto-instrumentation, opamp, github action)
5-
component: operator
5+
component: instrumentation, collector
66

77
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
88
note: "Add a must gather utility to help troubleshoot"
@@ -13,4 +13,13 @@ issues: [3149]
1313
# (Optional) One or more lines of additional information to render under the primary note.
1414
# These lines will be padded with 2 spaces and then inserted directly into the document.
1515
# Use pipe (|) for multiline entries.
16-
subtext: "The new utility is available as part of a new container image"
16+
subtext: |
17+
The new utility is available as part of a new container image.
18+
19+
To use the image in a running OpenShift cluster, you need to run the following command:
20+
21+
```sh
22+
oc adm must-gather --image=ghcr.io/open-telemetry/opentelemetry-operator/must-gather -- /usr/bin/must-gather --operator-namespace opentelemetry-operator-system
23+
```
24+
25+
See the [README](https://github.com/open-telemetry/opentelemetry-operator/blob/main/cmd/gather/README.md) for more details.

.github/workflows/publish-must-gather.yaml

+1-7
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: "Publish Python Auto-Instrumentation"
1+
name: "Publish must-gather image"
22

33
on:
44
push:
@@ -24,11 +24,6 @@ jobs:
2424
- name: Unshallow
2525
run: git fetch --prune --unshallow
2626

27-
- name: Set env vars for the job
28-
run: |
29-
echo "VERSION_DATE=$(date -u +'%Y-%m-%dT%H:%M:%SZ')" >> $GITHUB_ENV
30-
echo "VERSION=$(git describe --tags | sed 's/^v//')" >> $GITHUB_ENV
31-
3227
- name: Build the binary for each supported architecture
3328
run: |
3429
for platform in $(echo $PLATFORMS | tr "," "\n"); do
@@ -42,7 +37,6 @@ jobs:
4237
uses: docker/metadata-action@v5
4338
with:
4439
images: |
45-
otel/opentelemetry-operator-must-gather
4640
ghcr.io/open-telemetry/opentelemetry-operator/must-gather
4741
tags: |
4842
type=semver,pattern={{version}}

cmd/gather/README.md

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,18 @@ To run the must-gather tool for the OpenTelemetry Operator, use one of the follo
1919

2020
### Using the image from the Operator deployment
2121

22+
This is the recommended way to do it if you are not using OpenShift.
23+
2224
If you want to use the image in a running cluster, you need to run the following command:
2325

2426
```sh
25-
oc adm must-gather --image=<must-gather-image> -- /usr/bin/must-gather --operator-namespace opentelemetry-operator-system
27+
oc adm must-gather --image=ghcr.io/open-telemetry/opentelemetry-operator/must-gather -- /usr/bin/must-gather --operator-namespace opentelemetry-operator-system
2628
```
2729

2830
### Using it as a CLI
2931

3032
You only need to build and run:
3133
```sh
3234
make must-gather
33-
./bin/must-gather --help
35+
./bin/must-gather_$(go env GOARCH) --help
3436
```
35-
36-
This is the recommended way to do it if you are not using OpenShift.

0 commit comments

Comments
 (0)