Skip to content

Commit f16d7ef

Browse files
committed
Use api reader to avoid cache issues
Signed-off-by: Ruben Vargas <[email protected]>
1 parent b1d33cc commit f16d7ef

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

apis/v1beta1/metrics.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func BootstrapMetrics() (metric.MeterProvider, error) {
7272
return sdkmetric.NewMeterProvider(sdkmetric.WithReader(exporter)), err
7373
}
7474

75-
func NewMetrics(prv metric.MeterProvider, ctx context.Context, cl client.Client) (*Metrics, error) {
75+
func NewMetrics(prv metric.MeterProvider, ctx context.Context, cl client.Reader) (*Metrics, error) {
7676
meter := prv.Meter(meterName)
7777
modeCounter, err := meter.Int64UpDownCounter(modeMetricName)
7878
if err != nil {
@@ -120,7 +120,7 @@ func NewMetrics(prv metric.MeterProvider, ctx context.Context, cl client.Client)
120120
}
121121

122122
// Init metrics from the first time the operator starts.
123-
func (m *Metrics) init(ctx context.Context, cl client.Client) error {
123+
func (m *Metrics) init(ctx context.Context, cl client.Reader) error {
124124
opts := []client.ListOption{
125125
client.MatchingLabels(map[string]string{
126126
"app.kubernetes.io/managed-by": "opentelemetry-operator",

main.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -384,9 +384,9 @@ func main() {
384384
setupLog.Error(metricsErr, "Error bootstrapping CRD metrics")
385385
}
386386

387-
crdMetrics, err = otelv1beta1.NewMetrics(meterProvider, ctx, mgr.GetClient())
387+
crdMetrics, err = otelv1beta1.NewMetrics(meterProvider, ctx, mgr.GetAPIReader())
388388
if err != nil {
389-
setupLog.Error(err, "Error bootstrapping CRD metrics")
389+
setupLog.Error(err, "Error init CRD metrics")
390390
}
391391

392392
}

0 commit comments

Comments
 (0)