Skip to content

Commit f3f67df

Browse files
committed
Add additional logic for these disable variables
1 parent 305f6f7 commit f3f67df

File tree

1 file changed

+18
-1
lines changed

1 file changed

+18
-1
lines changed

internal/manifests/collector/annotations.go

+18-1
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,25 @@ func Annotations(instance v1beta1.OpenTelemetryCollector) (map[string]string, er
2727
// new map every time, so that we don't touch the instance's annotations
2828
annotations := map[string]string{}
2929

30+
var enableAnnotations bool
31+
// enableAnnotations is true only if both disable variables are false.
32+
// DisableAutomaticPrometheusAnnotations takes precedence over DisablePrometheusAnnotations.
33+
if instance.Spec.Observability.Metrics.DisableAutomaticPrometheusAnnotations {
34+
enableAnnotations = !instance.Spec.Observability.Metrics.DisableAutomaticPrometheusAnnotations
35+
} else if instance.Spec.Observability.Metrics.DisablePrometheusAnnotations {
36+
enableAnnotations = !instance.Spec.Observability.Metrics.DisablePrometheusAnnotations
37+
} else {
38+
enableAnnotations = true
39+
}
40+
if enableAnnotations {
41+
// Set default Prometheus annotations
42+
annotations["prometheus.io/scrape"] = "true"
43+
annotations["prometheus.io/port"] = "8888"
44+
annotations["prometheus.io/path"] = "/metrics"
45+
}
46+
3047
// Enable Prometheus annotations by default if DisablePrometheusAnnotations|DisableAutomaticPrometheusAnnotations is nil or true
31-
if !instance.Spec.Observability.Metrics.DisablePrometheusAnnotations || !instance.Spec.Observability.Metrics.DisableAutomaticPrometheusAnnotations {
48+
if !instance.Spec.Observability.Metrics.DisableAutomaticPrometheusAnnotations {
3249
// Set default Prometheus annotations
3350
annotations["prometheus.io/scrape"] = "true"
3451
annotations["prometheus.io/port"] = "8888"

0 commit comments

Comments
 (0)