Skip to content

Commit 24ecc80

Browse files
committed
fix imports order for ruff
1 parent 866c219 commit 24ecc80

File tree

4 files changed

+14
-26
lines changed

4 files changed

+14
-26
lines changed

instrumentation/opentelemetry-instrumentation-valkey/src/opentelemetry/instrumentation/valkey/__init__.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,6 +101,7 @@ def response_hook(span, instance, response):
101101

102102
from opentelemetry import trace
103103
from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
104+
from opentelemetry.instrumentation.utils import unwrap
104105
from opentelemetry.instrumentation.valkey.package import _instruments
105106
from opentelemetry.instrumentation.valkey.util import (
106107
_extract_conn_attributes,
@@ -109,7 +110,6 @@ def response_hook(span, instance, response):
109110
_value_or_none,
110111
)
111112
from opentelemetry.instrumentation.valkey.version import __version__
112-
from opentelemetry.instrumentation.utils import unwrap
113113
from opentelemetry.semconv.trace import SpanAttributes
114114
from opentelemetry.trace import Span, StatusCode, Tracer
115115

@@ -133,7 +133,9 @@ def response_hook(span, instance, response):
133133
valkey.asyncio.cluster.ClusterPipeline,
134134
)
135135
AsyncValkeyInstance = TypeVar(
136-
"AsyncValkeyInstance", valkey.asyncio.Valkey, valkey.asyncio.ValkeyCluster
136+
"AsyncValkeyInstance",
137+
valkey.asyncio.Valkey,
138+
valkey.asyncio.ValkeyCluster,
137139
)
138140
PipelineInstance = TypeVar(
139141
"PipelineInstance",

instrumentation/opentelemetry-instrumentation-valkey/tests/test_valkey.py

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -243,11 +243,9 @@ def test_attributes_default(self):
243243
span = spans[0]
244244
self.assertEqual(
245245
span.attributes[SpanAttributes.DB_SYSTEM],
246-
'valkey',
247-
)
248-
self.assertEqual(
249-
span.attributes['db.valkey.database_index'], 0
246+
"valkey",
250247
)
248+
self.assertEqual(span.attributes["db.valkey.database_index"], 0)
251249
self.assertEqual(
252250
span.attributes[SpanAttributes.NET_PEER_NAME], "localhost"
253251
)
@@ -269,11 +267,9 @@ def test_attributes_tcp(self):
269267
span = spans[0]
270268
self.assertEqual(
271269
span.attributes[SpanAttributes.DB_SYSTEM],
272-
'valkey',
273-
)
274-
self.assertEqual(
275-
span.attributes['db.valkey.database_index'], 1
270+
"valkey",
276271
)
272+
self.assertEqual(span.attributes["db.valkey.database_index"], 1)
277273
self.assertEqual(
278274
span.attributes[SpanAttributes.NET_PEER_NAME], "1.1.1.1"
279275
)
@@ -299,9 +295,7 @@ def test_attributes_unix_socket(self):
299295
span.attributes[SpanAttributes.DB_SYSTEM],
300296
"valkey",
301297
)
302-
self.assertEqual(
303-
span.attributes['db.valkey.database_index'], 3
304-
)
298+
self.assertEqual(span.attributes["db.valkey.database_index"], 3)
305299
self.assertEqual(
306300
span.attributes[SpanAttributes.NET_PEER_NAME],
307301
"/path/to/socket.sock",

tests/opentelemetry-docker-tests/tests/check_availability.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,8 @@ def check_postgres_connection():
111111
def check_redis_connection():
112112
connection = redis.Redis(host=REDIS_HOST, port=REDIS_PORT)
113113
connection.hgetall("*")
114-
114+
115+
115116
@retryable
116117
def check_valkey_connection():
117118
connection = valkey.Valkey(host=VALKEY_HOST, port=VALKEY_PORT)

tests/opentelemetry-docker-tests/tests/valkey/test_valkey_functional.py

Lines changed: 3 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -17,9 +17,6 @@
1717

1818
import valkey
1919
import valkey.asyncio
20-
from valkey.commands.search.indexDefinition import IndexDefinition, IndexType
21-
from valkey.commands.search.query import Query
22-
from valkey.exceptions import ResponseError
2320

2421
from opentelemetry import trace
2522
from opentelemetry.instrumentation.valkey import ValkeyInstrumentor
@@ -41,9 +38,7 @@ def tearDown(self):
4138
def _check_span(self, span, name):
4239
self.assertEqual(span.name, name)
4340
self.assertIs(span.status.status_code, trace.StatusCode.UNSET)
44-
self.assertEqual(
45-
span.attributes.get("db.valkey.database_index"), 0
46-
)
41+
self.assertEqual(span.attributes.get("db.valkey.database_index"), 0)
4742
self.assertEqual(
4843
span.attributes[SpanAttributes.NET_PEER_NAME], "localhost"
4944
)
@@ -287,9 +282,7 @@ def tearDown(self):
287282
def _check_span(self, span, name):
288283
self.assertEqual(span.name, name)
289284
self.assertIs(span.status.status_code, trace.StatusCode.UNSET)
290-
self.assertEqual(
291-
span.attributes.get("db.valkey.database_index"), 0
292-
)
285+
self.assertEqual(span.attributes.get("db.valkey.database_index"), 0)
293286
self.assertEqual(
294287
span.attributes[SpanAttributes.NET_PEER_NAME], "localhost"
295288
)
@@ -604,9 +597,7 @@ def _check_span(self, span, name):
604597
span.attributes[SpanAttributes.NET_PEER_NAME], "localhost"
605598
)
606599
self.assertEqual(span.attributes[SpanAttributes.NET_PEER_PORT], 16379)
607-
self.assertEqual(
608-
span.attributes["db.valkey.database_index"], 10
609-
)
600+
self.assertEqual(span.attributes["db.valkey.database_index"], 10)
610601

611602
def test_get(self):
612603
self.assertIsNone(self.valkey_client.get("foo"))

0 commit comments

Comments
 (0)