Skip to content

Inconsistent dependencies in opentelemetry-instrumentation-asyncclick #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
roma-frolov opened this issue Apr 25, 2025 · 6 comments · Fixed by #3447
Closed

Inconsistent dependencies in opentelemetry-instrumentation-asyncclick #3441

roma-frolov opened this issue Apr 25, 2025 · 6 comments · Fixed by #3447
Labels
bug Something isn't working instrumentation triaged

Comments

@roma-frolov
Copy link

roma-frolov commented Apr 25, 2025 •
edited
Loading

Describe your environment

OS: MacOS 15.3.2
Python version: Python 3.12.2
Package version: 0.53b1

What happened?

The package uses opentelemetry-instrumentation, but it is not included in the dependencies in pyproject.toml.

This causes an import error:

Traceback (most recent call last):
  File "/some/path/__main__.py", line 12, in <module>
    from opentelemetry.instrumentation.asyncclick import AsyncClickInstrumentor
  File "/some/path/.venv/lib/python3.12/site-packages/opentelemetry/instrumentation/asyncclick/__init__.py", line 70, in <module>
    from opentelemetry.instrumentation.instrumentor import BaseInstrumentor
ModuleNotFoundError: No module named 'opentelemetry.instrumentation.instrumentor'

I think the package is missing the opentelemetry-instrumentation dependency.

Steps to Reproduce

  1. pip install opentelemetry-instrumentation-asyncclick

from opentelemetry.instrumentation.asyncclick import AsyncClickInstrumentor

Expected Result

No errors

Actual Result

ModuleNotFoundError: No module named 'opentelemetry.instrumentation.instrumentor

Additional context

No response

Would you like to implement a fix?

Yes
@roma-frolov roma-frolov added the bug Something isn't working label Apr 25, 2025
@emdneto
Copy link
Member

emdneto commented Apr 25, 2025

@roma-frolov right. care to open a PR?

@jomcgi
Copy link
Contributor

jomcgi commented Apr 25, 2025

Please tag me if I can help - happy to open a PR as well.
Creating this issue has been on my todo list but life has been hectic for the last couple of weeks.

@roma-frolov
Copy link
Author

@roma-frolov right. care to open a PR?

yes

@roma-frolov
Copy link
Author

@emdneto @jomcgi

Sorry, I'll have to let someone else create a PR for this issue.

I have a local uv issue in this project, can't update uv.lock. Don't want to waste too much time on this. 🤕

@jomcgi
Copy link
Contributor

jomcgi commented Apr 26, 2025

Np I can share a PR.
I have a related issue for merging a devcontainer config to make it easier to contribute too. #3365

@jomcgi jomcgi mentioned this issue Apr 26, 2025
Merged
8 tasks
@jomcgi
Copy link
Contributor

jomcgi commented Apr 26, 2025

I could repro this with opentelemetry-instrumentation-click as well so have included the fix for that on my PR too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working instrumentation triaged
Projects
None yet
Milestone
No milestone
3 participants
@emdneto @roma-frolov @jomcgi