From 0af6ec301967f6e37e109bc9a492e4b20a916ab8 Mon Sep 17 00:00:00 2001 From: emdneto <9735060+emdneto@users.noreply.github.com> Date: Fri, 25 Apr 2025 17:50:22 -0300 Subject: [PATCH 1/2] fix sha-automation Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> --- .github/workflows/backport.yml | 3 +-- .../package-prepare-patch-release.yml | 3 +-- .github/workflows/package-prepare-release.yml | 6 ++--- .github/workflows/prepare-patch-release.yml | 12 +++++++--- .github/workflows/prepare-release-branch.yml | 24 ++++++++++++++----- 5 files changed, 31 insertions(+), 17 deletions(-) diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index 05488ecca3..26789093f2 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -40,5 +40,4 @@ jobs: gh pr create --title "[$GITHUB_REF_NAME] $title" \ --body "Clean cherry-pick of #$NUMBER to the \`$GITHUB_REF_NAME\` branch." \ --head $branch \ - --base $GITHUB_REF_NAME \ - --label backport + --base $GITHUB_REF_NAME diff --git a/.github/workflows/package-prepare-patch-release.yml b/.github/workflows/package-prepare-patch-release.yml index b540cf44c8..f216eada8a 100644 --- a/.github/workflows/package-prepare-patch-release.yml +++ b/.github/workflows/package-prepare-patch-release.yml @@ -118,5 +118,4 @@ jobs: gh pr create --title "[$GITHUB_REF_NAME] $message" \ --body "$message." \ --head $branch \ - --base $GITHUB_REF_NAME \ - --label prepare-release + --base $GITHUB_REF_NAME diff --git a/.github/workflows/package-prepare-release.yml b/.github/workflows/package-prepare-release.yml index 30c922d1ef..d596c4c74a 100644 --- a/.github/workflows/package-prepare-release.yml +++ b/.github/workflows/package-prepare-release.yml @@ -142,8 +142,7 @@ jobs: gh pr create --title "[$RELEASE_BRANCH_NAME] $message" \ --body "$message." \ --head $branch \ - --base $RELEASE_BRANCH_NAME \ - --label prepare-release + --base $RELEASE_BRANCH_NAME create-pull-request-against-main: runs-on: ubuntu-latest @@ -196,5 +195,4 @@ jobs: gh pr create --title "$message" \ --body "$body" \ --head $branch \ - --base main \ - --label prepare-release + --base main diff --git a/.github/workflows/prepare-patch-release.yml b/.github/workflows/prepare-patch-release.yml index 17d72e4cb4..d556ca3aea 100644 --- a/.github/workflows/prepare-patch-release.yml +++ b/.github/workflows/prepare-patch-release.yml @@ -71,6 +71,7 @@ jobs: run: .github/scripts/use-cla-approved-github-bot.sh - name: Create pull request + id: create_pr env: # not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} @@ -80,8 +81,13 @@ jobs: git commit -a -m "$message" git push origin HEAD:$branch - gh pr create --title "[$GITHUB_REF_NAME] $message" \ + pr_url=$(gh pr create --title "[$GITHUB_REF_NAME] $message" \ --body "$message." \ --head $branch \ - --base $GITHUB_REF_NAME \ - --label prepare-release + --base $GITHUB_REF_NAME) + echo "pr_url=$pr_url" >> $GITHUB_OUTPUT + + - name: Add prepare-release label to PR + if: steps.create_pr.outputs.pr_url != '' + run: | + gh pr edit ${{ steps.create_pr.outputs.pr_url }} --add-label "prepare-release" diff --git a/.github/workflows/prepare-release-branch.yml b/.github/workflows/prepare-release-branch.yml index 01689eae7f..e6ecd7483a 100644 --- a/.github/workflows/prepare-release-branch.yml +++ b/.github/workflows/prepare-release-branch.yml @@ -94,6 +94,7 @@ jobs: run: .github/scripts/use-cla-approved-github-bot.sh - name: Create pull request against the release branch + id: create_release_branch_pr env: # not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} @@ -103,11 +104,16 @@ jobs: git commit -a -m "$message" git push origin HEAD:$branch - gh pr create --title "[$RELEASE_BRANCH_NAME] $message" \ + pr_url=$(gh pr create --title "[$RELEASE_BRANCH_NAME] $message" \ --body "$message." \ --head $branch \ - --base $RELEASE_BRANCH_NAME \ - --label prepare-release + --base $RELEASE_BRANCH_NAME) + echo "pr_url=$pr_url" >> $GITHUB_OUTPUT + + - name: Add prepare-release label to PR + if: steps.create_release_branch_pr.outputs.pr_url != '' + run: | + gh pr edit ${{ steps.create_release_branch_pr.outputs.pr_url }} --add-label "prepare-release" create-pull-request-against-main: runs-on: ubuntu-latest @@ -180,6 +186,7 @@ jobs: run: .github/scripts/use-cla-approved-github-bot.sh - name: Create pull request against main + id: create_main_pr env: # not using secrets.GITHUB_TOKEN since pull requests from that token do not run workflows GITHUB_TOKEN: ${{ secrets.OPENTELEMETRYBOT_GITHUB_TOKEN }} @@ -190,8 +197,13 @@ jobs: git commit -a -m "$message" git push origin HEAD:$branch - gh pr create --title "$message" \ + pr_url=$(gh pr create --title "$message" \ --body "$body" \ --head $branch \ - --base main \ - --label prepare-release + --base main) + echo "pr_url=$pr_url" >> $GITHUB_OUTPUT + + - name: Add prepare-release label to PR + if: steps.create_main_pr.outputs.pr_url != '' + run: | + gh pr edit ${{ steps.create_main_pr.outputs.pr_url }} --add-label "prepare-release" From 38f38c22d3eee883911003751b014c2a1583cfd9 Mon Sep 17 00:00:00 2001 From: emdneto <9735060+emdneto@users.noreply.github.com> Date: Fri, 25 Apr 2025 17:54:44 -0300 Subject: [PATCH 2/2] use default github_token instead Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> --- .github/workflows/prepare-patch-release.yml | 2 ++ .github/workflows/prepare-release-branch.yml | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/.github/workflows/prepare-patch-release.yml b/.github/workflows/prepare-patch-release.yml index d556ca3aea..ccaffafea8 100644 --- a/.github/workflows/prepare-patch-release.yml +++ b/.github/workflows/prepare-patch-release.yml @@ -89,5 +89,7 @@ jobs: - name: Add prepare-release label to PR if: steps.create_pr.outputs.pr_url != '' + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | gh pr edit ${{ steps.create_pr.outputs.pr_url }} --add-label "prepare-release" diff --git a/.github/workflows/prepare-release-branch.yml b/.github/workflows/prepare-release-branch.yml index e6ecd7483a..1d9ff92c05 100644 --- a/.github/workflows/prepare-release-branch.yml +++ b/.github/workflows/prepare-release-branch.yml @@ -112,6 +112,8 @@ jobs: - name: Add prepare-release label to PR if: steps.create_release_branch_pr.outputs.pr_url != '' + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | gh pr edit ${{ steps.create_release_branch_pr.outputs.pr_url }} --add-label "prepare-release" @@ -205,5 +207,7 @@ jobs: - name: Add prepare-release label to PR if: steps.create_main_pr.outputs.pr_url != '' + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | gh pr edit ${{ steps.create_main_pr.outputs.pr_url }} --add-label "prepare-release"