Skip to content

Commit 2ddb076

Browse files
tammy-baylis-swixrmxlzchen
authored
Remove unused assertEqualSpanInstrumentationInfo (#4310)
* Remove assertEqualSpanInstrumentationInfo * Changelog * Update CHANGELOG.md Co-authored-by: Riccardo Magliocchetti <[email protected]> --------- Co-authored-by: Riccardo Magliocchetti <[email protected]> Co-authored-by: Leighton Chen <[email protected]>
1 parent 78653ef commit 2ddb076

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

CHANGELOG.md

+2
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
2121
([#4311](https://github.com/open-telemetry/opentelemetry-python/pull/4311))
2222
- sdk: fix serialization of logs severity_number field to int
2323
([#4324](https://github.com/open-telemetry/opentelemetry-python/pull/4324))
24+
- Remove `TestBase.assertEqualSpanInstrumentationInfo` method, use `assertEqualSpanInstrumentationScope` instead
25+
([#4310](https://github.com/open-telemetry/opentelemetry-python/pull/4310))
2426

2527
## Version 1.28.0/0.49b0 (2024-11-05)
2628

tests/opentelemetry-test-utils/src/opentelemetry/test/test_base.py

-4
Original file line numberDiff line numberDiff line change
@@ -70,10 +70,6 @@ def get_finished_spans(self):
7070
self, self.memory_exporter.get_finished_spans()
7171
)
7272

73-
def assertEqualSpanInstrumentationInfo(self, span, module):
74-
self.assertEqual(span.instrumentation_info.name, module.__name__)
75-
self.assertEqual(span.instrumentation_info.version, module.__version__)
76-
7773
def assertEqualSpanInstrumentationScope(self, span, module):
7874
self.assertEqual(span.instrumentation_scope.name, module.__name__)
7975
self.assertEqual(

0 commit comments

Comments
 (0)