-
Notifications
You must be signed in to change notification settings - Fork 691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OTLP export crashes with log message from twisted #4509
Comments
I found an old issue when researching the spec / history where the same fix (str fallback) was proposed. Some relevant comments:
Could this be resolved for the third party library through autoinstrumentation instead of requiring a core exporter to implement something that is outside of the spec? |
@lukaslihotzki-f Could you please give #4528 a try? |
Describe your environment
OS: Arch Linux
Python version: Python 3.13.2
SDK version: opentelemetry-sdk 1.31.0
API version: opentelemetry-api 1.31.0
What happened?
I integrated the OTLP exporter into synapse. When starting a new homeserver, this exception is raised:
Steps to Reproduce
Use the STDLibLogObserver from twisted, which passes a StringifiableFromEvent to the logger, which doesn't provide any interface supported by
_encode_value
.Expected Result
The stringified message body is logged.
Actual Result
Exception is raised, so logging fails for the whole batch.
Additional context
Ideally, exception handling during log record serializing would be per-record where it makes sense, so a failing record does not impact other log records in the same batch. However, this fix wouldn't be sufficient to get the expected result.
Would you like to implement a fix?
Yes
The text was updated successfully, but these errors were encountered: