Skip to content

Commit 19b5fbe

Browse files
authored
fix: add slash to .toys releases.yml directory to prevent gem release mismatch (#1799)
1 parent baeda39 commit 19b5fbe

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

.toys/.data/releases.yml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,11 @@ gems:
6060
version_constant: [OpenTelemetry, Exporter, Jaeger, VERSION]
6161

6262
- name: opentelemetry-exporter-otlp
63-
directory: exporter/otlp
63+
# we append a slash here to avoid the naive substring start_with? directory-matching condition in underlying toys gem
64+
# which casues exporter/otlp to incorrectly match when changes occur in exporter/otlp-logs or exporter/otlp-metrics
65+
# https://github.com/dazuma/toys/blob/17ed449da8299f272b834470ff6b279a59e8070b/.toys/release/.lib/release_utils.rb#L436
66+
# https://github.com/open-telemetry/opentelemetry-ruby/issues/1792
67+
directory: exporter/otlp/
6468
version_constant: [OpenTelemetry, Exporter, OTLP, VERSION]
6569

6670
- name: opentelemetry-exporter-otlp-logs

0 commit comments

Comments
 (0)