Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Automation: have link-check workflow commit the updated refcache #6127

Open
2 tasks
chalin opened this issue Jan 30, 2025 · 2 comments · Fixed by #6140 or #6147
Open
2 tasks

[CI] Automation: have link-check workflow commit the updated refcache #6127

chalin opened this issue Jan 30, 2025 · 2 comments · Fixed by #6140 or #6147
Assignees
Labels
CI/infra CI & infrastructure p2-medium

Comments

@chalin
Copy link
Contributor

chalin commented Jan 30, 2025

  • When a PR's check-links workflow fails because the refcache hasn't been updated, wouldn't be great if the job could just submit the updated refcache? It's already done all the work, might as well save it, no? Otherwise, we typically just end up issuing a fix:refcache command to achieve the same result.

    WDYT @svrnm @trask @open-telemetry/docs-maintainers?

  • While building the website for the purpose of checking links and building a new refcache, we might as well consider running some of the other fix commands that are quick to run, such as fix:dict, etc. Also see, [CI] Ensure that fix:dict etc get run as part of checks #6040.

@chalin chalin added the CI/infra CI & infrastructure label Jan 30, 2025
@chalin
Copy link
Contributor Author

chalin commented Jan 30, 2025

Of course, there's the possibility that we don't want the updated refcache to be committed. In those cases, which are more rare, we can always delete the commit.

@tiffany76
Copy link
Contributor

Giant +1!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure p2-medium
Projects
None yet
2 participants