Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve pipeline section docs #6176

Merged
merged 3 commits into from
Mar 1, 2025
Merged

Conversation

PadreSVK
Copy link
Contributor

@PadreSVK PadreSVK commented Feb 2, 2025

@PadreSVK PadreSVK requested a review from a team as a code owner February 2, 2025 18:23
Copy link

linux-foundation-easycla bot commented Feb 2, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: PadreSVK / name: Patrik Švikruha (f62946d, de9f9ed)
  • ✅ login: opentelemetrybot / name: OpenTelemetry Bot (ef80965)

@opentelemetrybot opentelemetrybot requested review from a team and mx-psi and removed request for a team February 2, 2025 18:23
Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left one comment, I am not a technical writer so it may be that others have a better suggestion here

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the suggested change from @mx-psi this looks good to me. If you can fix that, we can merge it in

@opentelemetrybot opentelemetrybot requested review from a team and bogdandrutu and removed request for a team February 6, 2025 14:14
@tiffany76
Copy link
Contributor

Hi @PadreSVK, please take a look at the most recent suggested changes so we can move this PR forward. Thanks!

@opentelemetrybot opentelemetrybot requested a review from a team February 26, 2025 11:01
@tiffany76
Copy link
Contributor

@svrnm, does this one look good to you?

@chalin
Copy link
Contributor

chalin commented Feb 27, 2025

/fix:format

@opentelemetrybot
Copy link
Collaborator

You triggered fix:format action run at https://github.com/open-telemetry/opentelemetry.io/actions/runs/13574933410

@opentelemetrybot
Copy link
Collaborator

fix:format was successful.

IMPORTANT: (RE-)RUN /fix:all to ensure that there are no remaining check issues.

@chalin
Copy link
Contributor

chalin commented Feb 28, 2025

@tiffany76 wrote:

@svrnm, does this one look good to you?

Since @svrnm is kinda out, and he only wanted to ensure that @mx-psi's comment was addressed; and @mx-psi has approved, let's consider this implicitly approved by @svrnm.

@tiffany76 tiffany76 merged commit cd90ab7 into open-telemetry:main Mar 1, 2025
18 checks passed
@opentelemetrybot
Copy link
Collaborator

Thank you for your contribution! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants