From fee9b7f2d6294e31ee9f2b586d50bb3feeee3d19 Mon Sep 17 00:00:00 2001 From: Zhengke Zhou Date: Wed, 19 Mar 2025 20:31:21 +0800 Subject: [PATCH 1/3] chore: refine Metric Gauges usage in Go SDK --- content/en/docs/languages/go/instrumentation.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/en/docs/languages/go/instrumentation.md b/content/en/docs/languages/go/instrumentation.md index 5eff300e52de..f5eac98c6424 100644 --- a/content/en/docs/languages/go/instrumentation.md +++ b/content/en/docs/languages/go/instrumentation.md @@ -551,6 +551,8 @@ import ( var fanSpeedSubscription chan int64 +var speedGauge metric.Int64Gauge + func init() { speedGauge, err := meter.Int64Gauge( "cpu.fan.speed", From 274df2c512b0879ca1c055e17c8801ed9f9c2f91 Mon Sep 17 00:00:00 2001 From: Zhengke Zhou Date: Thu, 20 Mar 2025 15:19:29 +0000 Subject: [PATCH 2/3] update --- content/en/docs/languages/go/instrumentation.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/content/en/docs/languages/go/instrumentation.md b/content/en/docs/languages/go/instrumentation.md index f5eac98c6424..4e46dc743711 100644 --- a/content/en/docs/languages/go/instrumentation.md +++ b/content/en/docs/languages/go/instrumentation.md @@ -512,8 +512,7 @@ import ( var itemsCounter metric.Int64UpDownCounter func init() { - var err error - itemsCounter, err = meter.Int64UpDownCounter( + itemsCounter, err := meter.Int64UpDownCounter( "items.counter", metric.WithDescription("Number of items."), metric.WithUnit("{item}"), @@ -549,9 +548,10 @@ import ( "go.opentelemetry.io/otel/metric" ) -var fanSpeedSubscription chan int64 - -var speedGauge metric.Int64Gauge +var ( + fanSpeedSubscription chan int64 + speedGauge metric.Int64Gauge +) func init() { speedGauge, err := meter.Int64Gauge( From 3b6c33bec634d935d3a08e1d8902dc511ddf8204 Mon Sep 17 00:00:00 2001 From: Zhengke Zhou Date: Thu, 20 Mar 2025 15:33:26 +0000 Subject: [PATCH 3/3] update --- content/en/docs/languages/go/instrumentation.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/content/en/docs/languages/go/instrumentation.md b/content/en/docs/languages/go/instrumentation.md index 4e46dc743711..8760a3316a10 100644 --- a/content/en/docs/languages/go/instrumentation.md +++ b/content/en/docs/languages/go/instrumentation.md @@ -512,7 +512,8 @@ import ( var itemsCounter metric.Int64UpDownCounter func init() { - itemsCounter, err := meter.Int64UpDownCounter( + var err error + itemsCounter, err = meter.Int64UpDownCounter( "items.counter", metric.WithDescription("Number of items."), metric.WithUnit("{item}"), @@ -554,7 +555,8 @@ var ( ) func init() { - speedGauge, err := meter.Int64Gauge( + var err error + speedGauge, err = meter.Int64Gauge( "cpu.fan.speed", metric.WithDescription("Speed of CPU fan"), metric.WithUnit("RPM"),