-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rendering] Enum values not sufficiently separate from attribute footnotes #1569
Comments
Add headers in order to separate enum value tables from the footnotes above. Fixes open-telemetry#1569
Add separators in order to separate enum value tables from the footnotes above. Fixes open-telemetry#1569
Add separators in order to separate enum value tables from the footnotes above. Fixes open-telemetry#1569
I created two draft PRs to better show what I'm asking for. If there in consensus on one of them i'll make it a real PR |
Another option could be to add make the enum values into a footnote on the attribute type, e.g.
[1]:
|
This solves another issue which is that the attribute table doesn't say anything about a list of acceptable values. If you look at the semconv I linked originally, nowhere does it say in the attribute table that edit: as long as we're considering larger changes, i'd also suggest to call it "extensible enum" instead of "string" for type. |
Area(s)
area:other
What happened?
Description
When markdown is rendered, the attributes table is followed by footnotes, then by tables which list values for enums. Those enum tables are not sufficiently separated from the footnotes, and they appear to be a part of the footnotes when reading. For example in HTTP client semconv the
error.type
table of possible values appears to be part of footnote [14] even though it is not.Example
Below is an example taken from HTTP client semconv that shows what I'm talking about
View example markdown
Above example rendered
What I'm asking for is some visual separation between these elements to make it more obvious that you have moved onto a separate section like this:
View example of suggested improved rendering (heading)
View example of suggested improved rendering (horizontal line separator)
Semantic convention version
v1.28.0
Additional context
No response
The text was updated successfully, but these errors were encountered: