Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should db.system be db.system.name? #1581

Open
jack-berg opened this issue Nov 14, 2024 · 0 comments
Open

Should db.system be db.system.name? #1581

jack-berg opened this issue Nov 14, 2024 · 0 comments

Comments

@jack-berg
Copy link
Member

Area(s)

area:db

Is your change request related to a problem? Please describe.

As we approach stability, I wanted to throw out a question of whether we should rename db.system to db.system.name in order to preserve the ability to use db.system as a namespace.

I don't see any need to include other db.system.* attributes on metrics / spans. But supposing semantic conventions expand to database servers (e.g. resource conventions to represent a database server), its possible we might want to include other attributes along the lines of db.system.version.

Describe the solution you'd like

Consider renaming db.system to db.system.name.

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant