Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modeling Design Patterns #16

Closed
pdelgosha22 opened this issue Dec 15, 2023 · 5 comments · Fixed by #20
Closed

Modeling Design Patterns #16

pdelgosha22 opened this issue Dec 15, 2023 · 5 comments · Fixed by #20

Comments

@pdelgosha22
Copy link
Collaborator

@MatthewSteen I have added figures subdirectory under guides. Feel free to move it somewhere else.
@lazlop Do you still want to keep the text you have added for this section
@steveraysteveray Feel free to edit my text

@steveraysteveray
Copy link
Contributor

I'm not seeing any subdirectory under guides...

@MatthewSteen
Copy link
Contributor

MatthewSteen commented Dec 15, 2023

@pdelgosha22 a few comments...

  1. If you don't put any files in a folder it doesn't show up here. It's common practice to put an empty .gitkeep file in a folder to initialize it.

  2. I suggest naming it images, or maybe we have both per the Sphinx docs, which distinguishes between the two. https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#directives

    • image (see also Images below)
    • figure (an image with caption and optional legend)
  3. The guides #1 issue is a place to discuss the overall content (files/pages) for the Guides section. I think we should then have a dedicated issue and PR for each one, like this one 👍🏻

@lazlop
Copy link
Collaborator

lazlop commented Dec 15, 2023

No need to keep any text! That was all just outlining/placeholder.

@MatthewSteen
Copy link
Contributor

I wonder if this is a better fit for the first tutorial if it's introducing the ontology in a more detail than the explanation/223.md, which would be a natural second page. Then the second tutorial would actually begin working with a model with Python.

@MatthewSteen MatthewSteen mentioned this issue Dec 15, 2023
@MatthewSteen
Copy link
Contributor

I wonder if this is a better fit for the first tutorial if it's introducing the ontology in a more detail than the explanation/223.md, which would be a natural second page. Then the second tutorial would actually begin working with a model with Python.

We agreed that this should remain in Guides as discussed in our meeting today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants