Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

example to align s223:Sensor with brick:*_Sensor #43

Open
VladimirAlexiev opened this issue Aug 30, 2024 · 2 comments
Open

example to align s223:Sensor with brick:*_Sensor #43

VladimirAlexiev opened this issue Aug 30, 2024 · 2 comments

Comments

@VladimirAlexiev
Copy link

https://docs.open223.info/guides/brick-rec.html#using-brick-points-with-223 shows this:

bldg:sensor a s223:Sensor ;
    s223:hasObservationLocation bldg:damper-out ;
    s223:hasPhysicalLocation bldg:damper ;
    s223:observes bldg:air-temp .

bldg:air-temp a s223:QuantifiableObservableProperty,
                brick:Supply_Air_Temperature_Sensor ;
    qudt:hasQuantityKind qudtqk:Temperature ;
    s223:hasAspect s223:Role-Supply ;
    qudt:hasUnit unit:DEG_C .

But why is the s223:QuantifiableObservableProperty instantiated as brick:Supply_Air_Temperature_Sensor?
I think that the s223:Sensor should be instantiated as brick:Supply_Air_Temperature_Sensor.

If so, then #42 also needs to be adjusted.

@steveraysteveray
Copy link
Contributor

I agree with @VladimirAlexiev, although I think he meant to say that bldg:sensor should be instantiated as brick:Supply_Air_Temperature_Sensor, not the class s223:Sensor.

@VladimirAlexiev
Copy link
Author

By "the property" and "the sensor" I mean instances of these respective classes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants