WEB-389: Fix date format issue when editing holidays

Fixed two issues in the holiday management feature:

1. Date Formatting Error:
   - Changed from formatDate() to formatDateAsString() to properly handle
     Java date format patterns (e.g., 'dd MMMM yyyy')
   - formatDate() uses Angular DatePipe which doesn't understand Java patterns
   - formatDateAsString() uses moment.js which correctly handles Java patterns
   - Applied fix to both edit and create holiday components

2. Submit Button Not Responding:
   - Added type='submit' attribute to submit button in edit-holiday template
   - This ensures the form's (ngSubmit) event is properly triggered

Files modified:
- src/app/organization/holidays/edit-holiday/edit-holiday.component.ts
- src/app/organization/holidays/edit-holiday/edit-holiday.component.html
- src/app/organization/holidays/create-holiday/create-holiday.component.ts

Author: AnvayKharb

src/app/organization/holidays/create-holiday/create-holiday.component.ts

@@ -332,11 +332,14 @@ export class CreateHolidayComponent implements OnInit {
     const locale = this.settings.language.code;
     const prevFromDate: Date = this.holidayForm.value.fromDate;
     const prevToDate: Date = this.holidayForm.value.toDate;
-    holidayFormData.fromDate = this.dateUtils.formatDate(prevFromDate, dateFormat);
-    holidayFormData.toDate = this.dateUtils.formatDate(prevToDate, dateFormat);
+    holidayFormData.fromDate = this.dateUtils.formatDateAsString(prevFromDate, dateFormat);
+    holidayFormData.toDate = this.dateUtils.formatDateAsString(prevToDate, dateFormat);
     if (this.holidayForm.contains('repaymentsRescheduledTo')) {
       const prevRepaymentsRescheduledTo: Date = this.holidayForm.value.repaymentsRescheduledTo;
-      holidayFormData.repaymentsRescheduledTo = this.dateUtils.formatDate(prevRepaymentsRescheduledTo, dateFormat);
+      holidayFormData.repaymentsRescheduledTo = this.dateUtils.formatDateAsString(
+        prevRepaymentsRescheduledTo,
+        dateFormat
+      );
     }
     const offices = this.holidayForm.value.offices.map((office: string) => {
       return { officeId: Number.parseInt(office, 10) };

src/app/organization/holidays/edit-holiday/edit-holiday.component.html

@@ -91,6 +91,7 @@
           {{ 'labels.buttons.Cancel' | translate }}
         </button>
         <button
+          type="submit"
           mat-raised-button
           color="primary"
           [disabled]="!holidayForm.valid"

src/app/organization/holidays/edit-holiday/edit-holiday.component.ts

@@ -134,17 +134,20 @@ export class EditHolidayComponent implements OnInit {
     const locale = this.settingsService.language.code;
     const dateFormat = this.settingsService.dateFormat;
     if (!this.isActiveHoliday) {
-      if (this.reSchedulingType === 2) {
-        const repaymentScheduledTo: Date = this.holidayForm.value.repaymentsRescheduledTo;
-        holidayFormData.repaymentsRescheduledTo = this.dateUtils.formatDate(repaymentScheduledTo, dateFormat);
-      }
       const prevFromDate: Date = this.holidayForm.value.fromDate;
       const prevToDate: Date = this.holidayForm.value.toDate;
-      if (holidayFormData.closureDate instanceof Date) {
-        holidayFormData.fromDate = this.dateUtils.formatDate(prevFromDate, dateFormat);
+
+      if (prevFromDate instanceof Date) {
+        holidayFormData.fromDate = this.dateUtils.formatDateAsString(prevFromDate, dateFormat);
       }
-      if (holidayFormData.closureDate instanceof Date) {
-        holidayFormData.toDate = this.dateUtils.formatDate(prevToDate, dateFormat);
+      if (prevToDate instanceof Date) {
+        holidayFormData.toDate = this.dateUtils.formatDateAsString(prevToDate, dateFormat);
+      }
+      if (this.reSchedulingType === 2) {
+        const repaymentScheduledTo: Date = this.holidayForm.value.repaymentsRescheduledTo;
+        if (repaymentScheduledTo instanceof Date) {
+          holidayFormData.repaymentsRescheduledTo = this.dateUtils.formatDateAsString(repaymentScheduledTo, dateFormat);
+        }
       }
     }
     const data = {