Skip to content

Commit 2372491

Browse files
committed
Possible resolution to web-100 - 'no account' messages
Provides possible resolution to web-100. 'No account' messages are displayed in whichever language is required. Now includes modified en-US.json file. Made an alteration to the Lithuanian json file, as the translation on line 3527, was from English to Latvian and not Lithuanian. Modified the Lithuanian, Italian, Czech, English and French .json translations files, as recommended by Coderabbit. Updated the main functionality - now filters empty/non-empty account types correctly. Further improvements to the translations files. html file now includes updated format and functionality
1 parent 5ed6524 commit 2372491

File tree

15 files changed

+206
-1804
lines changed

15 files changed

+206
-1804
lines changed

src/app/clients/clients-view/general-tab/general-tab.component.html

Lines changed: 71 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
<!--Version improved formatting and functionality, 29 October 2025-->
2+
13
<div class="tab-container mat-typography">
24
<h3>{{ 'labels.heading.Performance History' | translate }}</h3>
35
<div class="layout-row gap-32px performance-history-container">
@@ -112,6 +114,10 @@ <h3>{{ 'labels.heading.Upcoming Charges' | translate }}</h3>
112114
<div class="layout-column flex-50">
113115
<div class="heading-name">
114116
<h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3>
117+
<!-- No Loan Accounts Message -->
118+
<div class="no-account-message" *ngIf="!loanAccounts?.length">
119+
<h1>{{ 'labels.text.No loan accounts' | translate }}</h1>
120+
</div>
115121
</div>
116122
</div>
117123
<div class="layout-column flex-50">
@@ -302,6 +308,13 @@ <h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3>
302308
<div class="layout-column flex-50">
303309
<div class="heading-name">
304310
<h3>{{ 'labels.heading.Saving Accounts' | translate }}</h3>
311+
<!-- No Saving Account message -->
312+
<div
313+
class="no-account-message"
314+
*ngIf="!(savingAccounts | accountsFilter: 'saving' : 'open' : 'isSavings')?.length"
315+
>
316+
<h1>{{ 'labels.text.No saving accounts' | translate }}</h1>
317+
</div>
305318
</div>
306319
</div>
307320
<div class="layout-column flex-50">
@@ -439,11 +452,38 @@ <h3>{{ 'labels.heading.Saving Accounts' | translate }}</h3>
439452
></tr>
440453
</table>
441454

455+
<!-- loans accounts overview table
456+
<div class="heading-content">
457+
<div class="layout-column flex-50">
458+
<div class="heading-name">
459+
<h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3>
460+
No Loan Accounts Message
461+
<div class="no-account-message" *ngIf="!loanAccounts?.length">
462+
<h1>{{ 'labels.text.No loan accounts' | translate }}</h1>
463+
</div>
464+
</div>
465+
</div>
466+
<div class="layout-column flex-50">
467+
<div class="layout-row align-flex-end">
468+
<button mat-raised-button class="f-right" color="primary" (click)="toggleLoanAccountsOverview()">
469+
{{ viewAccountsLabel(showClosedLoanAccounts) | translate }}
470+
</button>
471+
</div>
472+
</div>
473+
</div> -->
474+
442475
<!-- Fixed Deposit Table -->
443476
<div class="heading-content">
444477
<div class="layout-column flex-50">
445478
<div class="heading-name">
446479
<h3>{{ 'labels.heading.Fixed Deposit Accounts' | translate }}</h3>
480+
<!-- No Fixed Deposit accounts message -->
481+
<div
482+
class="no-account-message"
483+
*ngIf="!(savingAccounts | accountsFilter: 'saving' : 'open' : 'isFixed')?.length"
484+
>
485+
<h1>{{ 'labels.text.No deposit accounts' | translate }}</h1>
486+
</div>
447487
</div>
448488
</div>
449489
<div class="layout-column flex-50">
@@ -565,6 +605,13 @@ <h3>{{ 'labels.heading.Fixed Deposit Accounts' | translate }}</h3>
565605
<div class="layout-column flex-50">
566606
<div class="heading-name">
567607
<h3>{{ 'labels.heading.Recurring Deposit Accounts' | translate }}</h3>
608+
<!-- No Recurring Deposit Accounts message -->
609+
<div
610+
class="no-account-message"
611+
*ngIf="!(savingAccounts | accountsFilter: 'saving' : 'open' : 'isRecurring')?.length"
612+
>
613+
<h1>{{ 'labels.text.No recurring accounts' | translate }}</h1>
614+
</div>
568615
</div>
569616
</div>
570617
<div class="layout-column flex-50">
@@ -689,11 +736,35 @@ <h3>{{ 'labels.heading.Recurring Deposit Accounts' | translate }}</h3>
689736
></tr>
690737
</table>
691738

739+
<!-- loans accounts overview table
740+
<div class="heading-content">
741+
<div class="layout-column flex-50">
742+
<div class="heading-name">
743+
<h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3>
744+
No Loan Accounts Message
745+
<div class="no-account-message" *ngIf="!loanAccounts?.length">
746+
<h1>{{ 'labels.text.No loan accounts' | translate }}</h1>
747+
</div>
748+
</div>
749+
</div>
750+
<div class="layout-column flex-50">
751+
<div class="layout-row align-flex-end">
752+
<button mat-raised-button class="f-right" color="primary" (click)="toggleLoanAccountsOverview()">
753+
{{ viewAccountsLabel(showClosedLoanAccounts) | translate }}
754+
</button>
755+
</div>
756+
</div>
757+
</div> -->
758+
692759
<!-- Shares overview Table -->
693760
<div class="heading-content">
694761
<div class="layout-column flex-50">
695762
<div class="heading-name">
696763
<h3>{{ 'labels.inputs.Shares Accounts' | translate }}</h3>
764+
<!-- No shares account message -->
765+
<div class="no-account-message" *ngIf="!shareAccounts?.length">
766+
<h1>{{ 'labels.text.No shares accounts' | translate }}</h1>
767+
</div>
697768
</div>
698769
</div>
699770
<div class="layout-column flex-50">

src/app/clients/clients-view/general-tab/general-tab.component.scss

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
//Version 4
2+
13
.tab-container {
24
padding: 1%;
35
margin: 1%;
@@ -48,3 +50,8 @@
4850
align-items: center; /* Ensure buttons are vertically aligned */
4951
gap: 0.5rem; /* Add spacing between buttons if needed */
5052
}
53+
54+
// New class for ‘no account available’ message.
55+
.no-account-message {
56+
color: blue;
57+
}

0 commit comments

Comments
 (0)