Skip to content

Possible resolution to web-100. #2645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Possible resolution to web-100. #2645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
71 changes: 71 additions & 0 deletions src/app/clients/clients-view/general-tab/general-tab.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<!--Version improved formatting and functionality, 29 October 2025-->

<div class="tab-container mat-typography">
<h3>{{ 'labels.heading.Performance History' | translate }}</h3>
<div class="layout-row gap-32px performance-history-container">
Expand Down Expand Up @@ -112,6 +114,10 @@ <h3>{{ 'labels.heading.Upcoming Charges' | translate }}</h3>
<div class="layout-column flex-50">
<div class="heading-name">
<h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3>
<!-- No Loan Accounts Message -->
<div class="no-account-message" *ngIf="!loanAccounts?.length">
<h1>{{ 'labels.text.No loan accounts' | translate }}</h1>
</div>
</div>
</div>
<div class="layout-column flex-50">
Expand Down Expand Up @@ -302,6 +308,13 @@ <h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3>
<div class="layout-column flex-50">
<div class="heading-name">
<h3>{{ 'labels.heading.Saving Accounts' | translate }}</h3>
<!-- No Saving Account message -->
<div
class="no-account-message"
*ngIf="!(savingAccounts | accountsFilter: 'saving' : 'open' : 'isSavings')?.length"
>
<h1>{{ 'labels.text.No saving accounts' | translate }}</h1>
</div>
</div>
</div>
<div class="layout-column flex-50">
Expand Down Expand Up @@ -439,11 +452,38 @@ <h3>{{ 'labels.heading.Saving Accounts' | translate }}</h3>
></tr>
</table>

<!-- loans accounts overview table
<div class="heading-content">
<div class="layout-column flex-50">
<div class="heading-name">
<h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3>
No Loan Accounts Message
<div class="no-account-message" *ngIf="!loanAccounts?.length">
<h1>{{ 'labels.text.No loan accounts' | translate }}</h1>
</div>
</div>
</div>
<div class="layout-column flex-50">
<div class="layout-row align-flex-end">
<button mat-raised-button class="f-right" color="primary" (click)="toggleLoanAccountsOverview()">
{{ viewAccountsLabel(showClosedLoanAccounts) | translate }}
</button>
</div>
</div>
</div> -->

<!-- Fixed Deposit Table -->
<div class="heading-content">
<div class="layout-column flex-50">
<div class="heading-name">
<h3>{{ 'labels.heading.Fixed Deposit Accounts' | translate }}</h3>
<!-- No Fixed Deposit accounts message -->
<div
class="no-account-message"
*ngIf="!(savingAccounts | accountsFilter: 'saving' : 'open' : 'isFixed')?.length"
>
<h1>{{ 'labels.text.No deposit accounts' | translate }}</h1>
</div>
</div>
</div>
<div class="layout-column flex-50">
Expand Down Expand Up @@ -565,6 +605,13 @@ <h3>{{ 'labels.heading.Fixed Deposit Accounts' | translate }}</h3>
<div class="layout-column flex-50">
<div class="heading-name">
<h3>{{ 'labels.heading.Recurring Deposit Accounts' | translate }}</h3>
<!-- No Recurring Deposit Accounts message -->
<div
class="no-account-message"
*ngIf="!(savingAccounts | accountsFilter: 'saving' : 'open' : 'isRecurring')?.length"
>
<h1>{{ 'labels.text.No recurring accounts' | translate }}</h1>
</div>
</div>
</div>
<div class="layout-column flex-50">
Expand Down Expand Up @@ -689,11 +736,35 @@ <h3>{{ 'labels.heading.Recurring Deposit Accounts' | translate }}</h3>
></tr>
</table>

<!-- loans accounts overview table
<div class="heading-content">
<div class="layout-column flex-50">
<div class="heading-name">
<h3>{{ 'labels.heading.Loan Accounts' | translate }}</h3>
No Loan Accounts Message
<div class="no-account-message" *ngIf="!loanAccounts?.length">
<h1>{{ 'labels.text.No loan accounts' | translate }}</h1>
</div>
</div>
</div>
<div class="layout-column flex-50">
<div class="layout-row align-flex-end">
<button mat-raised-button class="f-right" color="primary" (click)="toggleLoanAccountsOverview()">
{{ viewAccountsLabel(showClosedLoanAccounts) | translate }}
</button>
</div>
</div>
</div> -->

<!-- Shares overview Table -->
<div class="heading-content">
<div class="layout-column flex-50">
<div class="heading-name">
<h3>{{ 'labels.inputs.Shares Accounts' | translate }}</h3>
<!-- No shares account message -->
<div class="no-account-message" *ngIf="!shareAccounts?.length">
<h1>{{ 'labels.text.No shares accounts' | translate }}</h1>
</div>
</div>
</div>
<div class="layout-column flex-50">
Expand Down
7 changes: 7 additions & 0 deletions src/app/clients/clients-view/general-tab/general-tab.component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
//Version 4
Copy link

@coderabbitai coderabbitai bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Remove non-standard version comment from source code.

Version control should be managed via Git/VCS, not inline comments. The //Version 4 comment provides no actionable information and creates maintenance burden.

Delete line 1 and let git history track versions instead.

-//Version 4
-
 .tab-container {
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
//Version 4
.tab-container {
🤖 Prompt for AI Agents 
In src/app/clients/clients-view/general-tab/general-tab.component.scss around
lines 1 to 1 there is a non-standard inline version comment "//Version 4" that
should be removed; delete that single line so the file starts with its actual
styles and rely on Git/VCS history for versioning.


.tab-container {
padding: 1%;
margin: 1%;
Expand Down Expand Up @@ -48,3 +50,8 @@
align-items: center; /* Ensure buttons are vertically aligned */
gap: 0.5rem; /* Add spacing between buttons if needed */
}

// New class for ‘no account available’ message.
.no-account-message {
color: blue;
}
Loading