clang-format: re-format for clang-18

clang-format-18 isn't compatible with the clang-format-17 output, so we
need to reformat the code with the latest version.  The way clang-18
handles lambda formatting also changed, so we have made changes to the
organization default style format to better handle lambda formatting.

See I5e08687e696dd240402a2780158664b7113def0e for updated style.
See Iea0776aaa7edd483fa395e23de25ebf5a6288f71 for clang-18 enablement.

Change-Id: I21d2ca8065f24fd73509229c517f5caf48934b60
Signed-off-by: Patrick Williams <[email protected]>

Author: williamspatrick

.clang-format

@@ -87,7 +87,7 @@ IndentWidth:     4
 IndentWrappedFunctionNames: true
 InsertNewlineAtEOF: true
 KeepEmptyLinesAtTheStartOfBlocks: false
-LambdaBodyIndentation: OuterScope
+LambdaBodyIndentation: Signature
 LineEnding: LF
 MacroBlockBegin: ''
 MacroBlockEnd:   ''
@@ -98,13 +98,14 @@ ObjCSpaceAfterProperty: false
 ObjCSpaceBeforeProtocolList: true
 PackConstructorInitializers: BinPack
 PenaltyBreakAssignment: 25
-PenaltyBreakBeforeFirstCallParameter: 19
+PenaltyBreakBeforeFirstCallParameter: 50
 PenaltyBreakComment: 300
 PenaltyBreakFirstLessLess: 120
 PenaltyBreakString: 1000
+PenaltyBreakTemplateDeclaration: 10
 PenaltyExcessCharacter: 1000000
 PenaltyReturnTypeOnItsOwnLine: 60
-PenaltyIndentedWhitespace: 0
+PenaltyIndentedWhitespace: 1
 PointerAlignment: Left
 QualifierAlignment: Left
 ReferenceAlignment: Left

elog_block.hpp

@@ -43,11 +43,11 @@ class Block : public BlockIface
     Block(sdbusplus::bus_t& bus, const std::string& path, uint32_t entryId) :
         BlockIface(bus, path.c_str()), entryId(entryId)
     {
-        std::string entryPath{std::string(OBJ_ENTRY) + '/' +
-                              std::to_string(entryId)};
-        AssociationList assoc{std::make_tuple(std::string{"blocking_error"},
-                                              std::string{"blocking_obj"},
-                                              entryPath)};
+        std::string entryPath{
+            std::string(OBJ_ENTRY) + '/' + std::to_string(entryId)};
+        AssociationList assoc{
+            std::make_tuple(std::string{"blocking_error"},
+                            std::string{"blocking_obj"}, entryPath)};
         associations(std::move(assoc));
     };
 

elog_entry.hpp

@@ -79,8 +79,8 @@ class Entry : public EntryIfaces
         associations(std::move(objects), true);
         // Store a copy of associations in case we need to recreate
         assocs = associations();
-        sdbusplus::server::xyz::openbmc_project::logging::Entry::resolved(false,
-                                                                          true);
+        sdbusplus::server::xyz::openbmc_project::logging::Entry::resolved(
+            false, true);
 
         version(fwVersion, true);
         purpose(VersionPurpose::BMC, true);

elog_meta.cpp

@@ -49,9 +49,9 @@ void build<
     auto iter = metadata.find(match);
     if (metadata.end() != iter)
     {
-        list.emplace_back(std::make_tuple(CALLOUT_FWD_ASSOCIATION,
-                                          CALLOUT_REV_ASSOCIATION,
-                                          std::string(iter->second.c_str())));
+        list.emplace_back(
+            std::make_tuple(CALLOUT_FWD_ASSOCIATION, CALLOUT_REV_ASSOCIATION,
+                            std::string(iter->second.c_str())));
     }
 }
 

elog_meta.hpp

@@ -81,18 +81,16 @@ void build(const std::string& match, const std::vector<std::string>& data,
 // for this metadata.
 using namespace example::xyz::openbmc_project::example::elog;
 template <>
-inline void
-    build<TestErrorTwo::DEV_ID>(const std::string& /*match*/,
-                                const std::vector<std::string>& /*data*/,
-                                AssociationList& /*list*/)
+inline void build<TestErrorTwo::DEV_ID>(
+    const std::string& /*match*/, const std::vector<std::string>& /*data*/,
+    AssociationList& /*list*/)
 {}
 
 template <>
-inline void
-    build<example::xyz::openbmc_project::example::device::Callout::
-              CALLOUT_DEVICE_PATH_TEST>(const std::string& match,
-                                        const std::vector<std::string>& data,
-                                        AssociationList& list)
+inline void build<example::xyz::openbmc_project::example::device::Callout::
+                      CALLOUT_DEVICE_PATH_TEST>(
+    const std::string& match, const std::vector<std::string>& data,
+    AssociationList& list)
 {
     std::map<std::string, std::string> metadata;
     parse(data, metadata);

elog_serialize.hpp

@@ -38,9 +38,8 @@ bool deserialize(const fs::path& path, Entry& e);
  *                   be placed.
  *  @return fs::path - pathname of persisted error file
  */
-fs::path
-    getEntrySerializePath(uint32_t id,
-                          const fs::path& dir = fs::path(ERRLOG_PERSIST_PATH));
+fs::path getEntrySerializePath(
+    uint32_t id, const fs::path& dir = fs::path(ERRLOG_PERSIST_PATH));
 
 } // namespace logging
 } // namespace phosphor

extensions/openpower-pels/bcd_time.hpp

@@ -30,9 +30,8 @@ struct BCDTime
     BCDTime(uint8_t yearMSB, uint8_t yearLSB, uint8_t month, uint8_t day,
             uint8_t hour, uint8_t minutes, uint8_t seconds,
             uint8_t hundredths) :
-        yearMSB(yearMSB),
-        yearLSB(yearLSB), month(month), day(day), hour(hour), minutes(minutes),
-        seconds(seconds), hundredths(hundredths)
+        yearMSB(yearMSB), yearLSB(yearLSB), month(month), day(day), hour(hour),
+        minutes(minutes), seconds(seconds), hundredths(hundredths)
     {}
 
     bool operator==(const BCDTime& right) const;

extensions/openpower-pels/callout.cpp

@@ -96,8 +96,8 @@ Callout::Callout(CalloutPriority priority, const std::string& locationCode,
 
     setLocationCode(locationCode);
 
-    _fruIdentity = std::make_unique<FRUIdentity>(partNumber, ccin,
-                                                 serialNumber);
+    _fruIdentity =
+        std::make_unique<FRUIdentity>(partNumber, ccin, serialNumber);
 
     if (!mrus.empty())
     {
@@ -132,8 +132,8 @@ Callout::Callout(CalloutPriority priority, const std::string& symbolicFRU,
 
     setLocationCode(locationCode);
 
-    _fruIdentity = std::make_unique<FRUIdentity>(symbolicFRU, type,
-                                                 trustedLocationCode);
+    _fruIdentity =
+        std::make_unique<FRUIdentity>(symbolicFRU, type, trustedLocationCode);
 
     _size = flattenedSize();
 }

extensions/openpower-pels/callouts.cpp

@@ -55,8 +55,9 @@ void Callouts::addCallout(std::unique_ptr<Callout> callout)
     bool shouldAdd = true;
 
     // Check if there is already a callout for this FRU
-    auto it = std::ranges::find_if(
-        _callouts, [&callout](const auto& c) { return *callout == *c; });
+    auto it = std::ranges::find_if(_callouts, [&callout](const auto& c) {
+        return *callout == *c;
+    });
 
     // If the callout already exists, but the new one has a higher
     // priority, change the existing callout's priority to this