fs: fix/improve cpuacct.usage_all parsing #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lifubang PTAL |
kolyshkin
force-pushed
the
fix-usage-all
branch
from
14192a4 to
4bc37fa
Compare
AkihiroSuda
reviewed
Oct 30, 2025
cyphar
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
As @AkihiroSuda said, it would be nice if the commit message and/or test mentioned that this is necessary because of out-of-tree patches in Tencent's kernels, but otherwise LGTM.
First, we can reasonably expect the first three fields of
cpuacct.usage_all to be "cpu user system", even for future kernels,
and if we see something different, it doesn't make sense to continue.
So check that the header is as expected, and error out otherwise.
Second, if we have more than 3 values, and we've checked that the first
3 are as expected ("cpu user system"), we can safely ignore extra
columns. This fixes an issue on a custom kernel from Tencent, which
adds a few extra columns (see [1]), as reported in issue 46.
Add tests for both cases.
Fixes issue 46.
[1]: OpenCloudOS/TencentOS-kernel-0@0b66781
Reported-by: vimiix <[email protected]>
Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
force-pushed
the
fix-usage-all
branch
from
4bc37fa to
5777053
Compare
kolyshkin
changed the title
|
@lifubang PTAL 🙏🏻 |
AkihiroSuda
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #47, implementing ideas I left as review comments in there.
First, we can reasonably expect the first three fields of
cpuacct.usage_allto becpu user system, even for future kernels, and if we see something different, it doesn't make sense to continue. So check that the header is as expected, and error out otherwise.Second, if we have more than 3 values, and we've checked that the first 3 are as expected (
cpu user system), we can safely ignore extra columns. This fixes an issue on a custom kernel from Tencent, whichadds a few extra columns (see 1), as reported in #46.
Add tests for both cases.
Fixes: #46.