chore: fix open lint errors

Author: iloveagent57

enterprise_access/apps/api/authentication.py

@@ -63,7 +63,7 @@ def authenticate(self, request):
             )
             # Make the constructed event available to the view to avoid
             # reconstructing it again there.
-            setattr(request, "_stripe_event", event)
+            request._stripe_event = event  # pylint: disable=protected-access
         except ValueError as e:
             logger.exception('Invalid payload in Stripe webhook request: %s', e)
             raise exceptions.AuthenticationFailed('Invalid payload')
@@ -76,4 +76,3 @@ def authenticate(self, request):
 
         # Authentication succeeded - return None since webhooks don't have a user
         # The request is from Stripe's servers, not a logged-in user
-        return None

enterprise_access/apps/api/serializers/provisioning.py

@@ -235,15 +235,15 @@ class SubscriptionPlanOLIUpdateSerializer(BaseSerializer):
         help_text='Whether this OLI is for the trial plan (True) or paid plan (False).'
     )
 
-    def validate(self, data):
+    def validate(self, attrs):
         """
         Validates that exactly one of CheckoutIntent ``id`` and ``uuid`` is provided.
         """
-        if not (data.get('checkout_intent_id') or data.get('checkout_intent_uuid')):
+        if not (attrs.get('checkout_intent_id') or attrs.get('checkout_intent_uuid')):
             raise serializers.ValidationError('One of CheckoutIntent id or uuid is required')
-        if data.get('checkout_intent_id') and data.get('checkout_intent_uuid'):
+        if attrs.get('checkout_intent_id') and attrs.get('checkout_intent_uuid'):
             raise serializers.ValidationError('Only one of CheckoutIntent id or uuid can be provided')
-        return data
+        return attrs
 
 
 class SubscriptionPlanOLIUpdateResponseSerializer(BaseSerializer):

enterprise_access/apps/api/serializers/subsidy_requests.py

@@ -294,6 +294,18 @@ class LearnerCreditRequestApproveRequestSerializer(serializers.Serializer):
         help_text="The UUID of the SubsidyAccessPolicy to use for this approval."
     )
 
+    def create(self, validated_data):
+        """
+        Not implemented - this serializer is for validation only
+        """
+        raise NotImplementedError("This serializer is for validation only")
+
+    def update(self, instance, validated_data):
+        """
+        Not implemented - this serializer is for validation only
+        """
+        raise NotImplementedError("This serializer is for validation only")
+
 
 class LearnerCreditRequestApproveAllSerializer(serializers.Serializer):
     """
@@ -304,6 +316,18 @@ class LearnerCreditRequestApproveAllSerializer(serializers.Serializer):
         help_text="The UUID of the SubsidyAccessPolicy to use for this approval."
     )
 
+    def create(self, validated_data):
+        """
+        Not implemented - this serializer is for validation only
+        """
+        raise NotImplementedError("This serializer is for validation only")
+
+    def update(self, instance, validated_data):
+        """
+        Not implemented - this serializer is for validation only
+        """
+        raise NotImplementedError("This serializer is for validation only")
+
 
 # pylint: disable=abstract-method
 class LearnerCreditRequestCancelSerializer(serializers.Serializer):

enterprise_access/apps/api/tests/test_authentication.py

@@ -5,7 +5,6 @@
 from unittest import mock
 
 import stripe
-from django.conf import settings
 from django.test import RequestFactory, TestCase, override_settings
 from rest_framework.exceptions import AuthenticationFailed
 

enterprise_access/apps/api/utils.py

@@ -7,7 +7,6 @@
 
 from rest_framework.exceptions import ParseError
 
-from enterprise_access.apps.api_client.license_manager_client import LicenseManagerApiClient
 from enterprise_access.apps.bffs.api import (
     get_and_cache_enterprise_customer_users,
     transform_enterprise_customer_users_data

enterprise_access/apps/api/v1/tests/test_stripe_event_summary_views.py

@@ -1,7 +1,6 @@
 """
 Tests for StripEventSummary viewset.
 """
-import json
 import uuid
 from datetime import timedelta
 from urllib.parse import urlencode

enterprise_access/apps/api/v1/views/customer_billing.py

@@ -10,11 +10,11 @@
 from drf_spectacular.utils import OpenApiParameter, OpenApiResponse, OpenApiTypes, extend_schema, extend_schema_view
 from edx_rbac.decorators import permission_required
 from edx_rest_framework_extensions.auth.jwt.authentication import JwtAuthentication
-from rest_framework import exceptions, mixins, permissions, status, views, viewsets
+from rest_framework import exceptions, mixins, permissions, status, viewsets
 from rest_framework.decorators import action
 from rest_framework.response import Response
 
-from enterprise_access.apps.api import serializers, utils
+from enterprise_access.apps.api import serializers
 from enterprise_access.apps.api.authentication import StripeWebhookAuthentication
 from enterprise_access.apps.core.constants import (
     CUSTOMER_BILLING_CREATE_PORTAL_SESSION_PERMISSION,

enterprise_access/apps/customer_billing/tasks.py

@@ -109,7 +109,7 @@ def send_payment_receipt_email(
                 lms_user_id=admin.get('lms_user_id'),
             )
             recipients.append(recipient)
-        except Exception as exc:
+        except Exception as exc:  # pylint: disable=broad-exception-caught
             logger.warning(
                 'Failed to create Braze recipient for admin email %s: %s',
                 admin_email,
@@ -416,7 +416,7 @@ def send_trial_cancellation_email_task(
 
 
 @shared_task(base=LoggedTaskWithRetry)
-def send_trial_ending_reminder_email_task(checkout_intent_id):
+def send_trial_ending_reminder_email_task(checkout_intent_id):  # pylint: disable=too-many-statements
     """
     Send Braze email notification 72 hours before trial subscription ends.
 

enterprise_access/apps/customer_billing/tests/test_tasks.py

@@ -648,7 +648,7 @@ def test_no_payment_method(
     @mock.patch("enterprise_access.apps.customer_billing.tasks.BrazeApiClient")
     @mock.patch("enterprise_access.apps.customer_billing.tasks.LmsApiClient")
     def test_stripe_error_during_subscription_retrieval(
-        self, mock_lms_client, mock_braze_client, mock_get_subscription, mock_payment_method
+        self, mock_lms_client, mock_braze_client, mock_get_subscription, _mock_payment_method
     ):
         """Test handling of Stripe API errors."""
         mock_lms_instance = mock_lms_client.return_value

enterprise_access/apps/subsidy_access_policy/tests/test_models.py

@@ -3,7 +3,7 @@
 """
 import contextlib
 from datetime import datetime, timedelta
-from unittest.mock import ANY, MagicMock, PropertyMock, call, patch
+from unittest.mock import ANY, MagicMock, PropertyMock, patch
 from uuid import uuid4
 
 import ddt
@@ -62,7 +62,7 @@
 )
 from enterprise_access.apps.subsidy_request.constants import SubsidyRequestStates
 from enterprise_access.apps.subsidy_request.models import LearnerCreditRequest
-from enterprise_access.apps.subsidy_request.tests.factories import LearnerCreditRequestConfigurationFactory, UserFactory
+from enterprise_access.apps.subsidy_request.tests.factories import LearnerCreditRequestConfigurationFactory
 from enterprise_access.cache_utils import request_cache
 from enterprise_access.utils import localized_utcnow
 from test_utils import TEST_ENTERPRISE_GROUP_UUID, TEST_USER_RECORD, TEST_USER_RECORD_NO_GROUPS
@@ -1987,7 +1987,7 @@ def test_validate_prices_batch_mixed(self):
         }
 
         # Mock canonical prices.
-        def mock_price_side_effect(course_id, metadata):
+        def mock_price_side_effect(course_id, _metadata):
             prices = {'course-1': 5000, 'course-2': 5000, 'course-3': 5000, 'course-4': 5000}
             return prices.get(course_id)
         self.mock_canonical_price.side_effect = mock_price_side_effect
@@ -2076,7 +2076,7 @@ def test_can_allocate_all_price_validation_failure(self):
         ]
 
         # Mock canonical prices.
-        def mock_price_side_effect(course_id, metadata):
+        def mock_price_side_effect(_course_id, _metadata):
             return 5000  # Both are 5000 canonically.
         self.mock_canonical_price.side_effect = mock_price_side_effect