Adjusted grades should not greater than 100%

[mariajgrimaldi]

Expected behavior

There should be a validation check that the value is not greater than 100%, and it should show the updated value.

Actual behavior

Incorrect value and validation is missing

Steps to reproduce

1. Go to instructor's tab of a course with staff access
2. Go to student admin tab
3. click on view gradebook button
4. update student's grade to 99 and check if its updated correctly.

Additional information

Original issue: openedx/wg-build-test-release#357

[lkatsikaris]

Hi @mariajgrimaldi ! I tried this on a local branch and fixed it by comparing the value of the input with the possibleGrade (the maximum grade can take) and enabling the save button only if the value is minor than the possibleGrade (line 66).

Previously, I had to modify the useAdjustedGradeInputData hook to return the possible grade that we need in the comparison above, like this:

[mariajgrimaldi]

Hey, @lkatsikaris, thank you so much for trying that out! @jmakowski1123 @crathbun428: this is an enhancement for the grading configuration studio page. Could you review it from the product side? Let us know!

[lkatsikaris]

I created PR #402

[mariajgrimaldi]

Thank you, @lkatsikaris!

[marcotuts]

Setting this as the max makes sense to me! I imagine some people might want to allow for over 100% grades, but it seems reasonable to make this the default IMO.

[mariajgrimaldi]

New PR addressing this issue: #426

[farhaanbukhsh]

@mariajgrimaldi @bradenmacdonald pointed out that we should have a product review about this. Are we sure we want to put this restriction in place?

[bradenmacdonald]

@mariajgrimaldi @marcotuts ^

I think the PR currently forces grades to be no greater than 100% so we may need to make it overridable?