-
Notifications
You must be signed in to change notification settings - Fork 105
Convert Gradebook to frontend-base #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: frontend-base
Are you sure you want to change the base?
Conversation
BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <[email protected]>
Co-authored-by: jansenk <[email protected]>
Bumps [dawidd6/action-send-mail](https://github.com/dawidd6/action-send-mail) from 4 to 6. - [Release notes](https://github.com/dawidd6/action-send-mail/releases) - [Commits](dawidd6/action-send-mail@v4...v6) --- updated-dependencies: - dependency-name: dawidd6/action-send-mail dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: jansenk <[email protected]>
Co-authored-by: jansenk <[email protected]>
… / path fixes on files that had them
|
Thanks for the pull request, @holaontiveros! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
Bumping this for you, @holaontiveros! |
arbrandes
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the hard work! There's a lot to like, so apologies in advance for focusing on the problems.
In addition to the inline comments that focus on the code, these are the issues I found when running this, so far:
- The "Back to Dashboard" breadcrumb has its URL broken. Note the "undefined":
http://apps.local.openedx.io:1994/gradebook/undefined/courses/course-v1:Axim+DC01+dev/instructor - The header is not the same: the logo doesn't link back to the dashboard, there is no "Courses" link (which also links back to the dashboard), and the user menu is missing its content (fix in the inline comments)
- The page is missing the subtitle that displays the course ID ("course-v1:OpenedX+DemoX+DemoCourse")
- The search box is missing the placeholder "Search for a learner"
Otherwise, as mentioned above, things seem to be working just fine!
So we either use a placeholder for now or we play around with some CSS to override some default behaviours @arbrandes |

TL;DR -
Conversion to use frontend-base and match other apps
Fixes #497
What changed?
@edx/frontend-platform***to@openedx/frontend-baseTesting Instructions
Assuming you already have everything setup in your local to run frontend-base apps
rm -rf node_modulesand reinstall them npm cinpm run devThe app should be working but given the conversations with @arbrandes the tests are going to wait until we are able to migrate react-tes-utils in master and rebase them
Collectively, these should be completed by reviewers of this PR:
FYI: @openedx/content-aurora