Skip to content

Conversation

@holaontiveros
Copy link
Contributor

@holaontiveros holaontiveros commented Aug 11, 2025

TL;DR -
Conversion to use frontend-base and match other apps

Fixes #497

What changed?

  • Added dependencies required for frontend-base and recreated the lock so it works properly
  • Changed the base structure to match the compatible one for frontend-base
  • Changed all imports to be relative so it's compatible
  • Updated all references from @edx/frontend-platform*** to @openedx/frontend-base

Testing Instructions
Assuming you already have everything setup in your local to run frontend-base apps

  • make sure you are in the branch for this PR
  • clean all your node_modules rm -rf node_modules and reinstall them npm ci
  • run the dev server and verify you are able to access it npm run dev

The app should be working but given the conversations with @arbrandes the tests are going to wait until we are able to migrate react-tes-utils in master and rebase them

Collectively, these should be completed by reviewers of this PR:

  • I've done a visual code review
  • I've tested the new functionality

FYI: @openedx/content-aurora

brian-smith-tcril and others added 29 commits June 18, 2025 15:52
BREAKING CHANGE: Pre-design-tokens theming is no longer supported.

Co-authored-by: Diana Olarte <[email protected]>
Bumps [dawidd6/action-send-mail](https://github.com/dawidd6/action-send-mail) from 4 to 6.
- [Release notes](https://github.com/dawidd6/action-send-mail/releases)
- [Commits](dawidd6/action-send-mail@v4...v6)

---
updated-dependencies:
- dependency-name: dawidd6/action-send-mail
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Aug 11, 2025
@openedx-webhooks
Copy link

openedx-webhooks commented Aug 11, 2025

Thanks for the pull request, @holaontiveros!

This repository is currently maintained by @farhaanbukhsh.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Aug 11, 2025
@holaontiveros holaontiveros changed the title [WIP] Convert Gradebook to frontend-base Convert Gradebook to frontend-base Aug 13, 2025
@holaontiveros holaontiveros marked this pull request as ready for review August 13, 2025 19:02
@arbrandes arbrandes mentioned this pull request Aug 6, 2025
10 tasks
@arbrandes arbrandes self-requested a review August 13, 2025 20:25
@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Aug 14, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Aug 14, 2025
@mphilbrick211
Copy link

Bumping this for you, @holaontiveros!

Copy link
Contributor

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for all the hard work! There's a lot to like, so apologies in advance for focusing on the problems.

In addition to the inline comments that focus on the code, these are the issues I found when running this, so far:

  • The "Back to Dashboard" breadcrumb has its URL broken. Note the "undefined": http://apps.local.openedx.io:1994/gradebook/undefined/courses/course-v1:Axim+DC01+dev/instructor
  • The header is not the same: the logo doesn't link back to the dashboard, there is no "Courses" link (which also links back to the dashboard), and the user menu is missing its content (fix in the inline comments)
  • The page is missing the subtitle that displays the course ID ("course-v1:OpenedX+DemoX+DemoCourse")
  • The search box is missing the placeholder "Search for a learner"

Otherwise, as mentioned above, things seem to be working just fine!

@holaontiveros
Copy link
Contributor Author

Thank you for all the hard work! There's a lot to like, so apologies in advance for focusing on the problems.

In addition to the inline comments that focus on the code, these are the issues I found when running this, so far:

  • The "Back to Dashboard" breadcrumb has its URL broken. Note the "undefined": http://apps.local.openedx.io:1994/gradebook/undefined/courses/course-v1:Axim+DC01+dev/instructor
  • The header is not the same: the logo doesn't link back to the dashboard, there is no "Courses" link (which also links back to the dashboard), and the user menu is missing its content (fix in the inline comments)
  • The page is missing the subtitle that displays the course ID ("course-v1:OpenedX+DemoX+DemoCourse")
  • The search box is missing the placeholder "Search for a learner"

Otherwise, as mentioned above, things seem to be working just fine!

  • breadcrumbs url fixed one LMS_BASE_URL escaped from the first round
  • added slot for courses link, fixed roles for externalURls
  • fixed typo on route param :id -> :courseid
  • about the label there seems to be a mismatch in params from paragon v22 and v23, the component seems to be using inputLabel which is expected on paragon v23 but in 22 it's just label now the issue with that it's that it has a too long text for a label in v22 I think...
image

So we either use a placeholder for now or we play around with some CSS to override some default behaviours @arbrandes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

9 participants