Skip to content

Validate does not exit 1 on error #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
loeffel-io opened this issue Apr 11, 2025 · 2 comments · May be fixed by #485
Open

Validate does not exit 1 on error #484

loeffel-io opened this issue Apr 11, 2025 · 2 comments · May be fixed by #485
Assignees
@Siddhant-K-code
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@loeffel-io
Copy link

fga model validate --file {file} does not exit 1 if an model is wrong
can we please add this to support other tooling (bazel) to build on top of this

Thanks
@loeffel-io loeffel-io changed the title Validate does not exit 1 Validate does not exit 1 on error Apr 11, 2025
@rhamzeh rhamzeh added the bug Something isn't working label Apr 11, 2025
@rhamzeh rhamzeh moved this from Backlog to Ready in SDKs and Tooling Apr 11, 2025
@rhamzeh rhamzeh added the good first issue Good for newcomers label Apr 11, 2025
@rhamzeh
Copy link
Member

rhamzeh commented Apr 11, 2025

Thanks for calling that out @loeffel-io - yeah makes sense.

Added it as a good first issue, so feel free to send in a PR. Otherwise we'll probably push a fix over the next few weeks

@Siddhant-K-code Siddhant-K-code linked a pull request Apr 12, 2025 that will close this issue
Open
4 tasks
@Siddhant-K-code Siddhant-K-code self-assigned this Apr 12, 2025
@loeffel-io
Copy link
Author

thanks @Siddhant-K-code for the pr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Siddhant-K-code Siddhant-K-code

Labels
bug Something isn't working good first issue Good for newcomers
Projects
SDKs and Tooling
Status: Ready
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix validate command to exit with non-zero status on errors Siddhant-K-code/openfga-cli
3 participants
@rhamzeh @loeffel-io @Siddhant-K-code