refactor: Move Slack webhooks to common module #11479
Open
+162
−114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11479 +/- ##
==========================================
+ Coverage 49.71% 49.73% +0.01%
==========================================
Files 82 83 +1
Lines 22896 22913 +17
Branches 5492 5494 +2
==========================================
+ Hits 11383 11396 +13
- Misses 10124 10128 +4
Partials 1389 1389 ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
MongoDB
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves Slack hook calls to reusable module to avoid redundant similar code. Also makes the Slack Hook URL an environment option, so that it can be kept out of source control.